Modify test to ensure that all strategies have names #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… strategy has no name, it adopts the name attribute from the 'Player' class.
caddycarine
changed the title
gaffney2010
reviewed
Jul 5, 2020
| @@ -43,7 +43,7 @@ strategy's logic as default, we use :code:`Classifiers[<classifier>]( | |||
| <strategy>)`:: | |||
|
|
|||
| >>> from axelrod import Classifiers | |||
| >>> Classifiers['memory_depth'](axl.TitForTat) | |||
| >>> Classifiers['memory_depth'](axl.TitForTat()) | |||
There was a problem hiding this comment.
Why did this need to be changed?
There was a problem hiding this comment.
I think it's not necessary per se but there is a warning:
/.../classifier.py:196: UserWarning: Classifiers are intended to run on player instances. Passed player Tit For Tat was initialized with default arguments.
gaffney2010
approved these changes
Jul 6, 2020
marcharper
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test 'test_all_strategies_have_names' is always passed because when a strategy has no name, it adopts the name attribute from the 'Player' class.