Skip to content

Implemented Mikkelson, k66r from Axelrod's second. #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 22, 2018

Conversation

gaffney2010
Copy link
Member

Fairly straightforward implementation. I changed the variable J2 to credit = 7-J2. It's chosen so that credit is a good thing, and I center it at 7, so that we cooperate when credit is positive.

Fingerprints:

basic_fortran
basic_axelrod

@marcharper
Copy link
Member

The failing test is due to one of the ensemble strategies:

FAIL: test_strategy (axelrod.tests.strategies.test_meta.TestMetaMajorityLongMemory)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/Axelrod-Python/Axelrod/axelrod/tests/strategies/test_meta.py", line 340, in test_strategy
    expected_actions=actions, seed=1)
  File "/home/travis/build/Axelrod-Python/Axelrod/axelrod/tests/strategies/test_player.py", line 521, in versus_test
    self.assertEqual(match.play(), expected_actions)
AssertionError: Lists differ: [(C, C), (C, D), (C, C), (C, D), (D, C)] != [(C, C), (C, D), (D, C), (C, D), (D, C)]
First differing element 2:
(C, C)
(D, C)
- [(C, C), (C, D), (C, C), (C, D), (D, C)]
?                      --------
+ [(C, C), (C, D), (D, C), (C, D), (D, C)]

Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me: I have run the axelrod_fortran test suite locally and read through the strategies. Thanks @gaffney2010 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants