Skip to content

Refactor ResultSet #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
drvinceknight opened this issue Sep 22, 2016 · 1 comment
Closed

Refactor ResultSet #723

drvinceknight opened this issue Sep 22, 2016 · 1 comment
Assignees
@drvinceknight
Labels
enhancement

Comments

@drvinceknight
Copy link
Member

The ResultSet is not as efficient as ResultSetFromFile:

  • ResultSet goes through the interactions dictionary each time for every attribute calculation;
  • ResultSetFromFile reads through the file only once and calculates each attribute as it does.

This is not a difficult fix, basically porting the code from ResultSetFromFile that reads through the file to read through the dictionary.
@drvinceknight
Copy link
Member Author

Picking this one up.

@drvinceknight drvinceknight self-assigned this Oct 7, 2016
drvinceknight added a commit that referenced this issue Oct 7, 2016
@drvinceknight
Refactor ResultSet
57619e0 
Closes #723

This ensures that the ResultSet is as efficient as the
ResultSetFromFile.

This will make it easier to add more items to the result set in the
future.
drvinceknight added a commit that referenced this issue Oct 8, 2016
@drvinceknight
Refactor ResultSet
31e9de1 
Closes #723

This ensures that the ResultSet is as efficient as the
ResultSetFromFile.

This will make it easier to add more items to the result set in the
future.
drvinceknight added a commit that referenced this issue Oct 8, 2016
@drvinceknight
Refactor ResultSet
1426ae8 
Closes #723

This ensures that the ResultSet is as efficient as the
ResultSetFromFile.

This will make it easier to add more items to the result set in the
future.
@drvinceknight drvinceknight mentioned this issue Oct 8, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drvinceknight drvinceknight

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drvinceknight