chore(dev-deps): update @automattic/eslint-plugin-wpvip
#62
Conversation
| async function testHarness( replacements, customScript = null ) { | ||
| debug( replacements, customScript ); | ||
| const binary = process.env.CI === 'true' ? './bin/go-search-replace-test' : null; | ||
| const script = customScript || binary; | ||
| const result = await replace( readableStream, replacements, script ); | ||
| await new Promise( resolve => { | ||
|
|
||
| await /** @type {Promise<void>} */ ( new Promise( ( resolve ) => { |
There was a problem hiding this comment.
This weird syntax is to keep the TS validator happy.
| it( 'throws a new Error when the script/binary returns a non-zero exit code', async () => { | ||
| try { | ||
| // await replace( readableStream, [ 'thisdomain.com', 'thatdomain.com' ], nonZeroExitCodeScript ); | ||
| await testHarness( [ 'thisdomain.com', 'thatdomain.com' ], nonZeroExitCodeScript ); | ||
| } catch ( err ) { | ||
| expect( err ).toEqual( 'The search and replace process exited with a non-zero exit code: 1' ); | ||
| } | ||
| } ); | ||
| it( 'throws a new Error when the script/binary returns a non-zero exit code', () => | ||
| expect( testHarness( [ 'thisdomain.com', 'thatdomain.com' ], nonZeroExitCodeScript ) ).rejects.toEqual( 'The search and replace process exited with a non-zero exit code: 1' ), | ||
| ); |
There was a problem hiding this comment.
Our ESLint configuration does not like conditional expect. Luckily, we can replace the try...catch block with the .rejects matcher.
| fsMkdirSpy.mockResolvedValue(); | ||
| fsMkdirSpy.mockResolvedValue( undefined ); |
There was a problem hiding this comment.
Here and below: the function is expected to return something (in this case, undefined is fine). While the lack of value is technically undefined, the linter does not like this.
| function getLatestReleaseUrlForPlatformAndArch( { platform, arch } = {} ) { | ||
| function getLatestReleaseUrlForPlatformAndArch( { platform = '', arch = '' } = {} ) { |
There was a problem hiding this comment.
The linter insisted on having a default value.
| /** | ||
| * @param {{ arch?: string, platform?: string }} options | ||
| */ | ||
| async function downloadBinary( { arch = process.arch, platform = process.platform } = {} ) { |
There was a problem hiding this comment.
TIL that this works. Although there is no parameter named options. Oh well.
| return new Promise( async ( resolve, reject ) => { | ||
| let responseStream; | ||
| try { | ||
| responseStream = await downloadBinary( { platform, arch } ); | ||
| } catch ( downloadErr ) { | ||
| debug( { downloadErr } ); | ||
| return reject( downloadErr ); | ||
| } | ||
| let responseStream; | ||
| try { | ||
| responseStream = await downloadBinary( { platform, arch } ); | ||
| } catch ( downloadErr ) { | ||
| debug( { downloadErr } ); | ||
| return Promise.reject( downloadErr ); | ||
| } |
There was a problem hiding this comment.
This is because of the no-async-promise-executor rule. The suggestion was to reduce the scope of the Promise constructor, which worked.
| @@ -21,17 +21,10 @@ | |||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | |||
| * SOFTWARE. | |||
| */ | |||
| /** | |||
There was a problem hiding this comment.
Maybe keep external/internal dependencies comment?
There was a problem hiding this comment.
We removed them all in VIP CLI, I tried to be consistent :-)
| @@ -1,17 +1,12 @@ | |||
| /** | |||
| * External dependencies | |||
There was a problem hiding this comment.
Maybe keep external/internal dependencies comment?
Update
@automattic/eslint-plugin-wpvipto 0.9.1, remove extraneous eslint plugins, fix the code.I used Automattic/vip-cli#1577 as a template.