fix misleading compile error on multi-assignment #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersalomonsen
force-pushed
the
fix-multiassignment
branch
3 times, most recently
from
8150e34 to
28fdf3b
Compare
dcodeIO
reviewed
Feb 28, 2021
petersalomonsen
force-pushed
the
fix-multiassignment
branch
from
28fdf3b to
2c44783
Compare
multiassignment causes compiler error later on code that has no errors fix AssemblyScript#1699
petersalomonsen
force-pushed
the
fix-multiassignment
branch
from
2c44783 to
86706dd
Compare
|
Ouch :) |
|
ouch what ? :) Ready for review now @dcodeIO |
|
Ouch as in "what the heck did I think when I wrote that code" 😄 |
|
Perfect, thanks for the fix! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiassignment causes compiler error later on code that has no errors
fix #1699
⯈
⯈
⯈