Skip to content

refactor: remove redundant transaction methods #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025
Merged

refactor: remove redundant transaction methods #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e9ebd7
remove redundant tx endpoint methods
alexbarnsley Mar 27, 2025
9c8d336
Merge remote-tracking branch 'origin/feat/mainsail' into refactor/rem…
alexbarnsley Mar 27, 2025
b6e0507
Merge remote-tracking branch 'origin/feat/mainsail' into refactor/rem…
alexbarnsley Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions src/API/Transactions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,36 +64,6 @@ public function getUnconfirmed(string $id): ?array
return $this->withApi('transactions')->requestGet("transactions/unconfirmed/{$id}");
}

/**
* Get a list of valid transaction types.
*
* @return array
*/
public function types(): ?array
{
return $this->requestGet('transactions/types');
}

/**
* Get the list of static transaction fees.
*
* @return array
*/
public function fees(): ?array
{
return $this->requestGet('transactions/fees');
}

/**
* Get the list of transaction schemas.
*
* @return array
*/
public function schemas(): ?array
{
return $this->requestGet('transactions/schemas');
}

/**
* Get the pool configuration.
*
Expand Down
24 changes: 0 additions & 24 deletions tests/API/TransactionsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,30 +66,6 @@ public function get_unconfirmed_calls_correct_url()
);
}

/** @test */
public function types_calls_correct_url()
{
$this->assertResponse('GET', 'transactions/types', function ($client) {
return $client->transactions()->types();
});
}

/** @test */
public function fees_calls_correct_url()
{
$this->assertResponse('GET', 'transactions/fees', function ($client) {
return $client->transactions()->fees();
});
}

/** @test */
public function schemas_calls_correct_url()
{
$this->assertResponse('GET', 'transactions/schemas', function ($client) {
return $client->transactions()->schemas();
});
}

/** @test */
public function configuration_calls_correct_url()
{
Expand Down