-
Notifications
You must be signed in to change notification settings - Fork 0
plotly 6.0.1 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plotly 6.0.1 #12
Conversation
An error on win-64:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - but missing imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth trying to run their unit tests or do they require our CI to have a head? As Andrii pointed out, there are also a fair number of new import paths that could be checked.
There are unusually long builds on Windows, see also plotly/plotly.py#1208. I'm afraid that enabling tests for Windows will take more than 4-6 hours. But I can try on Unix platforms |
The source code on PyPI doesn't contain tests, so I'll skip it for now. |
Destination channel: main
Links
Explanation of changes:
tenacity
fromrun
Notes:
No issues found.