Skip to content

plotly 6.0.1 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2025
Merged

plotly 6.0.1 #12

merged 3 commits into from
Apr 18, 2025

Conversation

skupr-anaconda
Copy link

@skupr-anaconda skupr-anaconda commented Apr 16, 2025

Destination channel: main

Links

Explanation of changes:

  • Reset build number from 1 to 0
  • Remove tenacity from run
  • Remove several import tests for modules that have been deprecated or removed:
_plotly_utils
_plotly_utils.colors
_plotly_future_
plotly.graph_objs.heatmapgl
plotly.graph_objs.pointcloud
plotly.validators.heatmapgl
plotly.validators.pointcloud
  • Completely remove abs.yaml file

Notes:

  • I've tested the package with donwstreams:
Downstream build order (groups:() feedstocks:('plotly-feedstock',) packages:() allow_list:() block_list:() drop_noarch:False sections:('build', 'host', 'run')):

000 dash-feedstock                 ['dash']
001 anaconda-feedstock             ['_anaconda_depends', '_anaconda_core', '__anaconda_core_depends']
001 chart-studio-feedstock         ['chart-studio']
001 plotly-resampler-feedstock     ['plotly-resampler']
002 anaconda_custom-feedstock      ['anaconda']
002 autovizwidget-feedstock        ['autovizwidget']
002 bertopic-feedstock             ['bertopic']
002 catboost-feedstock             ['catboost']
002 dash-bio-feedstock             ['dash-bio']
002 glue-core-feedstock            ['glue-core']
002 interpret-feedstock            ['interpret']
002 python-cufflinks-feedstock     ['python-cufflinks']
002 sdmetrics-feedstock            ['sdmetrics']
002 statsforecast-feedstock        ['statsforecast']
002 streamlit-plotly-events-feedstock ['streamlit-plotly-events']

No issues found.

@skupr-anaconda skupr-anaconda self-assigned this Apr 16, 2025
@skupr-anaconda skupr-anaconda marked this pull request as ready for review April 16, 2025 14:24
@skupr-anaconda
Copy link
Author

An error on win-64:

usage: py_compile.py [-h] [-q] filenames [filenames ...]
py_compile.py: error: the following arguments are required: filenames

Copy link

@Andrii-Osipov Andrii-Osipov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but missing imports

Copy link

@bwingconda bwingconda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth trying to run their unit tests or do they require our CI to have a head? As Andrii pointed out, there are also a fair number of new import paths that could be checked.

@skupr-anaconda
Copy link
Author

Is it worth trying to run their unit tests or do they require our CI to have a head? As Andrii pointed out, there are also a fair number of new import paths that could be checked.

There are unusually long builds on Windows, see also plotly/plotly.py#1208. I'm afraid that enabling tests for Windows will take more than 4-6 hours. But I can try on Unix platforms

@skupr-anaconda
Copy link
Author

Is it worth trying to run their unit tests or do they require our CI to have a head? As Andrii pointed out, there are also a fair number of new import paths that could be checked.

There are unusually long builds on Windows, see also plotly/plotly.py#1208. I'm afraid that enabling tests for Windows will take more than 4-6 hours. But I can try on Unix platforms

The source code on PyPI doesn't contain tests, so I'll skip it for now.

@skupr-anaconda skupr-anaconda merged commit a6b229f into master Apr 18, 2025
3 of 7 checks passed
@skupr-anaconda skupr-anaconda deleted the 6.0.1 branch April 18, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants