Repo creation test #4
Conversation
| const page = await context.newPage(); | ||
|
|
||
| const response = await page.goto('/repo/create'); | ||
| await expect(response?.status()).toBe(200); // Status OK |
There was a problem hiding this comment.
Can we add some visual assertions to make sure the new repo page elements are loading correctly?
Maybe select some of (or all) of the dropdowns and make sure they appear? We've had issues with that breaking before.
Might want to look at the code for this and see if there is any javascript that's running and see if we can stress those code paths.
There was a problem hiding this comment.
I wonder if it's reasonable to add ids to make the selectors a little less finicky
There was a problem hiding this comment.
Many of the dropdowns have selectors that collide which makes it a little tricky. Adding ids would be useful for more comprehensive testing.
There was a problem hiding this comment.
Yeah, I think we should add an ID where the selectors are more tricky.
There was a problem hiding this comment.
Should we tackle that in this PR?
kdumontnu
force-pushed
the
kd/ci-playwright_go_test
branch
3 times, most recently
from
a538f06 to
a18ed34
Compare
Changes