Skip to content

UDS-1992:fix(components-core): added focus css for accordion wrapper #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
+9 −0
Open

UDS-1992:fix(components-core): added focus css for accordion wrapper #1522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6b3046
fix(components-core): added tabindex and focus css for accordion wrapper
juanmitriatti Apr 21, 2025
2dd45e2
fix(components-core): removed tabIndex 0 from Accordion
juanmitriatti May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/unity-bootstrap-theme/src/scss/extends/_cards.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,6 +691,15 @@ Cards - Table of Contents
7. Accordion
--------------------------------------------------------------------*/
.accordion {

&:focus {
outline: none!important;
box-shadow: 0 0 0 1px $uds-color-base-gray-7 !important;
border: 1px solid $uds-color-base-gray-7 !important;
margin: 4px;
width: -webkit-fill-available;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed. change is needed in unity-react-core, not in css

.accordion-item {
border-bottom: 1px solid $uds-color-base-gray-3;
border-top: 1px solid $uds-color-base-gray-3;
Expand Down