Skip to content

GCS ACLE #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 15, 2025
Merged

GCS ACLE #364

merged 4 commits into from
Jan 15, 2025

Conversation

yury-khrustalev
Copy link
Contributor

@yury-khrustalev yury-khrustalev commented Nov 25, 2024

This is to continue discussion started in #260.


name: Pull request
about: Technical issues, document format problems, bugs in scripts or feature proposal.


@yury-khrustalev yury-khrustalev mentioned this pull request Nov 25, 2024
8 tasks
@yury-khrustalev
Copy link
Contributor Author

The only difference compared to #260 is use of non-const type for GCS pointer (an relevant change in wording).

Copy link
Contributor

@DanielKristofKiss DanielKristofKiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me, just a note from me.
let see what others says.

@yury-khrustalev yury-khrustalev force-pushed the gcs branch 2 times, most recently from 70ac9c6 to a6e18dd Compare December 2, 2024 11:37
Co-authored-by: Yury Khrustalev <[email protected]>
@john-brawn-arm
Copy link

LGTM

Copy link
Contributor

@DanielKristofKiss DanielKristofKiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vhscampos vhscampos merged commit 67e0c53 into ARM-software:main Jan 15, 2025
4 checks passed
sivan-shani added a commit to sivan-shani/llvm-project that referenced this pull request Apr 23, 2025
The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)

Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the signature accordingly to:
void *__gcsss(void *)

This aligns the implementation with the latest ACLE definition.
sivan-shani added a commit to sivan-shani/llvm-project that referenced this pull request Apr 23, 2025
The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)

Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the signature accordingly to:
void *__gcsss(void *)

This aligns the implementation with the latest ACLE definition.
sivan-shani added a commit to llvm/llvm-project that referenced this pull request Apr 24, 2025
#136850)

The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)

Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the
signature accordingly to: void *__gcsss(void *)

This aligns the implementation with the latest ACLE definition.
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request May 6, 2025
…pecification (#136850)

The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)

Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the
signature accordingly to: void *__gcsss(void *)

This aligns the implementation with the latest ACLE definition.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
llvm#136850)

The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)

Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the
signature accordingly to: void *__gcsss(void *)

This aligns the implementation with the latest ACLE definition.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
llvm#136850)

The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)

Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the
signature accordingly to: void *__gcsss(void *)

This aligns the implementation with the latest ACLE definition.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
llvm#136850)

The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)

Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the
signature accordingly to: void *__gcsss(void *)

This aligns the implementation with the latest ACLE definition.
Ankur-0429 pushed a commit to Ankur-0429/llvm-project that referenced this pull request May 9, 2025
llvm#136850)

The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)

Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the
signature accordingly to: void *__gcsss(void *)

This aligns the implementation with the latest ACLE definition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants