Skip to content

Fix witness during login and wallet tests #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 7, 2025
Merged

Fix witness during login and wallet tests #749

merged 6 commits into from
May 7, 2025

Conversation

Agusx1211
Copy link
Member

No description provided.

@Agusx1211 Agusx1211 requested a review from Copilot May 7, 2025 14:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issues with the wallet login and logout flows by updating tests and related logic, including fixing witness execution, updating signer status expectations, and refining configuration for Ethereum mocking and DB handling.

  • Updated wallet tests to use the "actionable" status instead of "ready" for mnemonic signers.
  • Introduced a witness call in the device creation flow.
  • Adjusted cron job implementation and migrated relayer configuration to a function.

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/wallet/wdk/test/wallets.test.ts Added and updated wallet login/logout tests to reflect signer status and witness behavior.
packages/wallet/wdk/test/setup.ts Updated Ethereum mocking to use LOCAL_RPC_URL.
packages/wallet/wdk/test/sessions.test.ts Updated signer status checks in session tests.
packages/wallet/wdk/test/recovery.test.ts Removed hard-coded network configuration from recovery tests.
packages/wallet/wdk/test/constants.ts Added newManager and configuration defaults for test isolation.
packages/wallet/wdk/src/sequence/wallets.ts Added witness invocation for device registration.
packages/wallet/wdk/src/sequence/manager.ts Changed relayers configuration to a function and added DB-stop logic.
packages/wallet/wdk/src/sequence/handlers/mnemonic.ts Updated mnemonic handler return type and status.
packages/wallet/wdk/src/sequence/cron.ts Refactored cron jobs to handle graceful stopping and chaining properly.
packages/wallet/wdk/src/dbs/generic.ts Added a close method for DB cleanup.
README.md Updated the testing instructions regarding anvil and forge requirements.
Files not reviewed (1)
  • package.json: Language not supported

@Agusx1211 Agusx1211 marked this pull request as ready for review May 7, 2025 14:24
@Agusx1211 Agusx1211 requested review from a team as code owners May 7, 2025 14:24
@Agusx1211 Agusx1211 merged commit 4b7067a into master May 7, 2025
3 checks passed
@Agusx1211 Agusx1211 deleted the test-wdk branch May 7, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant