Add regex evaluation timeout (#404)

mokarchi · web-flow · commit 48cbb294b7b1 · 2024-02-22T15:20:30.000-08:00
diff --git a/src/xunit.runner.visualstudio/Utility/RunSettings.cs b/src/xunit.runner.visualstudio/Utility/RunSettings.cs
@@ -233,7 +233,7 @@ public bool IsMatchingTargetFramework()
 	}
 
 	// This should match .NET versions like 'net6.0' but not .NET Framework version like 'net462'.
-	static readonly Regex regexNet5Plus = new(@"^net\d+\.\d+$");
+	static readonly Regex regexNet5Plus = new(@"^net\d+\.\d+$", RegexOptions.Multiline | RegexOptions.Compiled | RegexOptions.IgnoreCase, TimeSpan.FromSeconds(1));
 
 	static bool IsNetCore(string targetFrameworkVersion) =>
 		targetFrameworkVersion.StartsWith(".NETCoreApp,", StringComparison.OrdinalIgnoreCase) ||

Original file line number	Diff line number	Diff line change
`@@ -233,7 +233,7 @@ public bool IsMatchingTargetFramework()`
`233`	`233`	`}`
`234`	`234`
`235`	`235`	`// This should match .NET versions like 'net6.0' but not .NET Framework version like 'net462'.`
`236`		`- static readonly Regex regexNet5Plus = new(@"^net\d+\.\d+$");`
	`236`	`+ static readonly Regex regexNet5Plus = new(@"^net\d+\.\d+$", RegexOptions.Multiline \| RegexOptions.Compiled \| RegexOptions.IgnoreCase, TimeSpan.FromSeconds(1));`
`237`	`237`
`238`	`238`	`static bool IsNetCore(string targetFrameworkVersion) =>`
`239`	`239`	`targetFrameworkVersion.StartsWith(".NETCoreApp,", StringComparison.OrdinalIgnoreCase) \|\|`