Skip to content

Scroll Behavior to.hash not call decodeURIComponent #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SCWR opened this issue Oct 21, 2020 · 1 comment
Closed

Scroll Behavior to.hash not call decodeURIComponent #3353

SCWR opened this issue Oct 21, 2020 · 1 comment

Comments

@SCWR
Copy link

SCWR commented Oct 21, 2020

The final wrong position is

https://github.com/vuepress/vuepress-plugin-smooth-scroll/blob/master/src/enhanceApp.ts#L16

vuepress-plugin-smooth-scroll

This document is used here.

https://router.vuejs.org/guide/advanced/scroll-behavior.html#async-scrolling

There was no problem before because the to.hash returned by vue-router was call decodeURIComponent.

Since version 3.4.3, the uncoded hash has been returned directly.

Originally posted by @SCWR in vuejs/vuepress#2599 (comment)

@vue-bot
Copy link

vue-bot commented Oct 21, 2020

Hello, thank you for taking time filling this issue!

However, we kindly ask you to use our Issue Helper when creating new issues, in order to ensure every issue provides the necessary information for us to investigate. This explains why your issue has been automatically closed by me (your robot friend!).

I hope to see your helper-created issue very soon!

@vue-bot vue-bot closed this as completed Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants