Silence default child warning when redirecting (#1442)

* Silence default child warning when redirecting

There is no need to warn about a named route that has a default child
route if the named route intentionally redirects.

* Updates create-map spec for redirecting route

Author: decademoon

src/create-route-map.js

@@ -83,11 +83,11 @@ function addRouteRecord (
   }
 
   if (route.children) {
-    // Warn if route is named and has a default child route.
+    // Warn if route is named, does not redirect and has a default child route.
     // If users navigate to this route by name, the default child will
     // not be rendered (GH Issue #629)
     if (process.env.NODE_ENV !== 'production') {
-      if (route.name && route.children.some(child => /^\/?$/.test(child.path))) {
+      if (route.name && !route.redirect && route.children.some(child => /^\/?$/.test(child.path))) {
         warn(
           false,
           `Named Route '${route.name}' has a default child route. ` +

test/unit/specs/create-map.spec.js

@@ -23,6 +23,19 @@ const routes = [
         name: 'bar.baz'
       }
     ]
+  },
+  {
+    path: '/bar-redirect',
+    name: 'bar-redirect',
+    redirect: { name: 'bar-redirect.baz' },
+    component: Bar,
+    children: [
+      {
+        path: '',
+        component: Baz,
+        name: 'bar-redirect.baz'
+      }
+    ]
   }
 ]
 
@@ -44,7 +57,7 @@ describe('Creating Route Map', function () {
   })
 
   it('has a pathList which places wildcards at the end', () => {
-    expect(maps.pathList).toEqual(['', '/foo', '/bar/', '/bar', '*'])
+    expect(maps.pathList).toEqual(['', '/foo', '/bar/', '/bar', '/bar-redirect/', '/bar-redirect', '*'])
   })
 
   it('has a nameMap object for default subroute at \'bar.baz\'', function () {
@@ -54,7 +67,7 @@ describe('Creating Route Map', function () {
   it('in development, has logged a warning concerning named route of parent and default subroute', function () {
     process.env.NODE_ENV = 'development'
     maps = createRouteMap(routes)
-    expect(console.warn).toHaveBeenCalled()
+    expect(console.warn).toHaveBeenCalledTimes(1)
     expect(console.warn.calls.argsFor(0)[0]).toMatch('vue-router] Named Route \'bar\'')
   })