A bunch of fixes for the next branch #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the event onChange is triggered twice, once by PrismEditor textarea (payload: Event) and once by the Editor (payload: code string)
elevatebart
reviewed
Oct 21, 2020
| @@ -61,6 +61,7 @@ const highlight = (lang, jsxInExamples) => { | |||
|
|
|||
| export default { | |||
| name: "VueLiveEditor", | |||
| inheritAttrs: false, | |||
There was a problem hiding this comment.
Just curious. Why was this one necessary?
There was a problem hiding this comment.
Otherwise the @change defined in VueLive.vue is inherited by PrismEditor component in Editor.vue. Then, when the editor value changes, it trigger the event twice; once by PrismEditor textarea (payload: Event, undesired) and once by the Editor (payload: code string, desired).
elevatebart
pushed a commit
that referenced
this pull request
Oct 21, 2020
* refactor: abandon functional components * fix: avoid warning of VueLiveDefaultLayout made reactive * fix: prevent PrismEditor from inheriting Editor props Otherwise the event onChange is triggered twice, once by PrismEditor textarea (payload: Event) and once by the Editor (payload: code string) * fix: externalize Vue from library bundle
elevatebart
added a commit
that referenced
this pull request
May 1, 2022
* fix: first compiling version * fix: demo remove use of datepicker unused * First release of a vue 3 compatible vue-live (#53) * feat: new next configuration for sem rel BREAKING CHANGE: will deliver the next branch as alpha next * fix: hook on the right event * fix: use global h hyperscript * fix: protect empty script * fix: install vue-3 datepicker * docs: use the new date picker * docs: add a comment * build: ren semantic on next * build: run travis on next branch * test: fix cypress * fix: A bunch of fixes for the next branch (#55) * refactor: abandon functional components * fix: avoid warning of VueLiveDefaultLayout made reactive * fix: prevent PrismEditor from inheriting Editor props Otherwise the event onChange is triggered twice, once by PrismEditor textarea (payload: Event) and once by the Editor (payload: code string) * fix: externalize Vue from library bundle * docs: fix vue aliases * docs: update path of vuejs * Update README.md * fix: use acorn walk instead of recast visit For vite esm compat * fix: remove recast remains * style: update comment * fix: allow aria and dashed attributes closes #59 * test: update test to make colon acceptable * fix: CSS scope ID (#64) * chore: release alpha 6 * fix: ci update caniuse * fix: allow for $ variables and functions handlers * build: vue plugin before others for sfc * fix: release semrel * feat: create allow list for camelCased SVG attributes (#67) Co-authored-by: Michael Dodge <[email protected]> * fix: make npm start work again * fix: make it run without eslint errors * fix: make it run * fix: update dependency and make jsx work * build: eslint configuration * build: fix unit test using jest * fix: update inbrowser compiler for vite compat * fix: remove console.log * ci: remove travis from vue-live Co-authored-by: Benoît Burgener <[email protected]> Co-authored-by: Maksym Shopynskyi <[email protected]> Co-authored-by: mgdodge <[email protected]> Co-authored-by: Michael Dodge <[email protected]>
elevatebart
added a commit
that referenced
this pull request
Jun 2, 2022
* fix: first compiling version * fix: demo remove use of datepicker unused * First release of a vue 3 compatible vue-live (#53) * feat: new next configuration for sem rel BREAKING CHANGE: will deliver the next branch as alpha next * fix: hook on the right event * fix: use global h hyperscript * fix: protect empty script * fix: install vue-3 datepicker * docs: use the new date picker * docs: add a comment * build: ren semantic on next * build: run travis on next branch * test: fix cypress * fix: A bunch of fixes for the next branch (#55) * refactor: abandon functional components * fix: avoid warning of VueLiveDefaultLayout made reactive * fix: prevent PrismEditor from inheriting Editor props Otherwise the event onChange is triggered twice, once by PrismEditor textarea (payload: Event) and once by the Editor (payload: code string) * fix: externalize Vue from library bundle * docs: fix vue aliases * docs: update path of vuejs * Update README.md * fix: use acorn walk instead of recast visit For vite esm compat * fix: remove recast remains * style: update comment * fix: allow aria and dashed attributes closes #59 * test: update test to make colon acceptable * fix: CSS scope ID (#64) * chore: release alpha 6 * fix: ci update caniuse * fix: allow for $ variables and functions handlers * build: vue plugin before others for sfc * fix: release semrel * feat: create allow list for camelCased SVG attributes (#67) Co-authored-by: Michael Dodge <[email protected]> * fix: make npm start work again * fix: make it run without eslint errors * fix: make it run * fix: update dependency and make jsx work * build: eslint configuration * build: fix unit test using jest * fix: update inbrowser compiler for vite compat * fix: remove console.log * fix: build script with vite needs ordering of imports * ci: run release on next Co-authored-by: Benoît Burgener <[email protected]> Co-authored-by: Maksym Shopynskyi <[email protected]> Co-authored-by: mgdodge <[email protected]> Co-authored-by: Michael Dodge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I couldn’t come with a better title 😅
I tested the next branch within a project and came across a couple of issues. Here are the changes I made to make it work.