Use *net.URL as parameter for DownloadIndex

This will turn out useful on next commits

Author: cmaglie

common/net_functions.go

@@ -35,20 +35,21 @@ import (
 	"io"
 	"io/ioutil"
 	"net/http"
+	"net/url"
 	"os"
 	"time"
 
 	"github.com/bcmi-labs/arduino-cli/pathutils"
 )
 
 // DownloadIndex is a function to download a generic index.
-func DownloadIndex(indexPath pathutils.Path, URL string) error {
+func DownloadIndex(indexPath pathutils.Path, URL *url.URL) error {
 	file, err := indexPath.Get()
 	if err != nil {
 		return err
 	}
 
-	req, err := http.NewRequest("GET", URL, nil)
+	req, err := http.NewRequest("GET", URL.String(), nil)
 	if err != nil {
 		return err
 	}

cores/packageindex/index.go

@@ -32,6 +32,7 @@ package packageindex
 import (
 	"encoding/json"
 	"io/ioutil"
+	"net/url"
 
 	"github.com/bcmi-labs/arduino-cli/common/releases"
 
@@ -41,7 +42,7 @@ import (
 )
 
 // packageIndexURL contains the index URL for core packages.
-const packageIndexURL = "https://downloads.arduino.cc/packages/package_index.json"
+var packageIndexURL, _ = url.Parse("https://downloads.arduino.cc/packages/package_index.json")
 
 // coreIndexPath returns the path of the index file for libraries.
 var coreIndexPath = configs.IndexPath("package_index.json")

libraries/download.go

@@ -30,13 +30,13 @@
 package libraries
 
 import (
+	"net/url"
+
 	"github.com/bcmi-labs/arduino-cli/common"
 )
 
-const (
-	// libraryIndexURL is the URL where to get library index.
-	libraryIndexURL string = "http://downloads.arduino.cc/libraries/library_index.json"
-)
+// libraryIndexURL is the URL where to get library index.
+var libraryIndexURL, _ = url.Parse("http://downloads.arduino.cc/libraries/library_index.json")
 
 // DownloadLibrariesFile downloads the lib file from arduino repository.
 func DownloadLibrariesFile() error {