test config added, fixed tests using test config file

Author: saniales

cmd/.test-config.yml

@@ -0,0 +1,3 @@
+proxy_type: auto
+sketchbook_path: /home/bcmi/Arduino
+arduino_data: /home/bcmi/.arduino15

cmd/arduino.go

@@ -99,6 +99,7 @@ arduino core version # for the version of the core component.`,
 }
 
 var bundled bool
+var testing = false
 
 func init() {
 	versions[ArduinoCmd.Name()] = ArduinoVersion
@@ -107,6 +108,19 @@ func init() {
 	InitCommands()
 }
 
+// TestInit creates an initialization for tests
+func TestInit() {
+	InitFlags()
+	InitCommands()
+	InitConfigs()
+
+	cobra.OnInitialize(func() {
+		viper.SetConfigFile("./test-config.yml")
+	})
+
+	testing = true
+}
+
 // InitFlags reinitialize flags (useful for testing too)
 func InitFlags() {
 	ArduinoCmd.ResetFlags()
@@ -197,7 +211,9 @@ func arduinoPreRun(cmd *cobra.Command, args []string) {
 		})
 	}
 
-	cobra.OnInitialize(initViper)
+	if !testing {
+		cobra.OnInitialize(initViper)
+	}
 }
 
 func arduinoRun(cmd *cobra.Command, args []string) error {
@@ -223,6 +239,7 @@ func arduinoRun(cmd *cobra.Command, args []string) error {
 func Execute() {
 	err := ArduinoCmd.Execute()
 	if err != nil {
+		formatter.PrintError(err)
 		os.Exit(1)
 	}
 }
@@ -298,8 +315,8 @@ func initViper() {
 
 	err := viper.ReadInConfig()
 	if err != nil {
+		formatter.PrintError(err)
 		formatter.PrintErrorMessage("Cannot read configuration file in any of the default folders")
-		os.Exit(1) //Exit with error is OK here?
 	}
 
 	viper.SetDefault("paths.sketchbook", defHome)
@@ -315,7 +332,7 @@ func initViper() {
 		hostname := viper.GetString("proxy.hostname")
 		if hostname == "" {
 			formatter.PrintErrorMessage("With manual proxy configuration, hostname is required.")
-			os.Exit(1)
+			os.Exit(2)
 		}
 
 		if strings.HasPrefix(hostname, "http") {

cmd/arduino_boards.go

@@ -2,8 +2,13 @@ package cmd
 
 import (
 	"errors"
+	"fmt"
 	"time"
 
+	"github.com/bcmi-labs/arduino-cli/common"
+
+	"github.com/bcmi-labs/arduino-modules/boards"
+
 	"github.com/bcmi-labs/arduino-cli/cmd/formatter"
 
 	"github.com/arduino/board-discovery"
@@ -43,7 +48,7 @@ func executeBoardListCommand(cmd *cobra.Command, args []string) {
 
 	formatter.Print(*monitor)
 	//monitor.Stop() //If called will slow like 1sec the program to close after print, with the same result (tested).
-	// it closes gracefully, but at the end of the command we can't have races.
+	// it closes ungracefully, but at the end of the command we can't have races.
 }
 
 func executeBoardAttachCommand(cmd *cobra.Command, args []string) error {
@@ -58,9 +63,20 @@ func executeBoardAttachCommand(cmd *cobra.Command, args []string) error {
 
 	formatter.Print(*monitor)
 
-	serialDevices := monitor.Serial()
-	for name, device := range serialDevices {
+	packageFolder, err := common.GetDefaultPkgFolder()
+	if err != nil {
+		formatter.PrintErrorMessage("Cannot Parse Board Index file")
+		return nil
+	}
+	boards, err := boards.Find(packageFolder)
+	if err != nil {
+		formatter.PrintErrorMessage("Cannot Parse Board Index file")
+		return nil
+	}
 
+	fmt.Println("SUPPORTED BOARDS:")
+	for _, device := range monitor.Serial() {
+		fmt.Println(boards.ByVidPid(device.ProductID, device.VendorID))
 	}
 
 	return nil

cmd/cmd_test.go

@@ -31,6 +31,7 @@ package cmd_test
 
 import (
 	"encoding/json"
+	"fmt"
 	"io/ioutil"
 	"os"
 	"strings"
@@ -56,6 +57,7 @@ func createTempRedirect(t *testing.T) *os.File {
 	tempFile, err := ioutil.TempFile(os.TempDir(), "test")
 	require.NoError(t, err, "Opening temp file")
 	os.Stdout = tempFile
+
 	return tempFile
 }
 
@@ -67,12 +69,13 @@ func cleanTempRedirect(t *testing.T, tempFile *os.File) {
 }
 
 func executeWithArgs(t *testing.T, args ...string) {
-	cmd.InitFlags()
-	cmd.InitCommands()
+	cmd.TestInit()
 	if args != nil {
 		cmd.ArduinoCmd.SetArgs(args)
 	}
+
 	err := cmd.ArduinoCmd.Execute()
+	fmt.Fprintln(stdOut, err)
 	require.NoError(t, err, "Error executing command")
 }
 

cmd/formatter/formatter.go

@@ -54,7 +54,7 @@ var debug bool
 func init() {
 	formatters = make(map[string]Formatter, 2)
 	AddCustomFormatter("text", &TextFormatter{})
-	AddCustomFormatter("json", &JSONFormatter{Debug: true})
+	AddCustomFormatter("json", &JSONFormatter{})
 	defaultFormatter = formatters["text"]
 
 	printFunc = defaultPrintFunc

configs/configs.go

@@ -68,15 +68,15 @@ func getFileLocation() string {
 
 // Configs represents the possible configurations for the CLI.
 type Configs struct {
-	ProxyType         string        `yaml:"proxy_type,required"`
+	ProxyType         string        `yaml:"proxy_type"`
 	ProxyManualConfig *ProxyConfigs `yaml:"manual_configs,omitempty"`
 	SketchbookPath    string        `yaml:"sketchbook_path,omitempty"`
 	ArduinoDataFolder string        `yaml:"arduino_data,omitempty"`
 }
 
 //ProxyConfigs represents a possible manual proxy configuration.
 type ProxyConfigs struct {
-	Hostname string `yaml:"hostname,required"`
+	Hostname string `yaml:"hostname"`
 	Username string `yaml:"username,omitempty"`
 	Password string `yaml:"password,omitempty"` // can be encrypted, see issue #71
 }

libraries/common.go

@@ -32,11 +32,11 @@ import "strings"
 
 // NameVersionPair represents a pair Name - Version.
 type NameVersionPair struct {
-	Name    string
-	Version string
+	Name    string // The name of the parsed item.
+	Version string // The Version of the parsed item.
 }
 
-// ParseLibArgs parses a sequence of "item@version" tokens and returns a Name-Version slice.
+// ParseArgs parses a sequence of "item@version" tokens and returns a Name-Version slice.
 //
 // If version is not present it is assumed as "latest" version.
 func ParseArgs(args []string) []NameVersionPair {