core download feature terminated but not tested

Author: saniales

cmd/arduino.go

@@ -90,7 +90,8 @@ var arduinoVersionCmd = &cobra.Command{
 	Long:  `Shows version Number of arduino CLI components which are installed on your system.`,
 	Run:   executeVersionCommand,
 	Example: `arduino version     # for the versions of all components.
-arduino lib version # for the version of the lib component.`,
+arduino lib version # for the version of the lib component.
+arduino core version # for the version of the core component.`,
 }
 
 func init() {

cmd/arduino_core.go

@@ -43,6 +43,11 @@ import (
 	"github.com/spf13/cobra"
 )
 
+const (
+	// CoreVersion represents the `arduino core` package version number.
+	CoreVersion string = "0.1.0-alpha.preview"
+)
+
 var arduinoCoreCmd = &cobra.Command{
 	Use:     "core",
 	Short:   "Arduino Core operations",
@@ -51,6 +56,15 @@ var arduinoCoreCmd = &cobra.Command{
 	Example: `arduino core --update-index to update the package index file`,
 }
 
+// arduinoCoreVersionCmd represents the version command.
+var arduinoCoreVersionCmd = &cobra.Command{
+	Use:     "version",
+	Short:   "Shows version Number of arduino core package",
+	Long:    `Shows version Number of arduino core package which is installed on your system.`,
+	Run:     executeVersionCommand,
+	Example: arduinoVersionCmd.Example,
+}
+
 var arduinoCoreListCmd = &cobra.Command{
 	Use:   "list",
 	Short: "Shows the list of installed cores",
@@ -74,6 +88,7 @@ func init() {
 	arduinoCmd.AddCommand(arduinoCoreCmd)
 	arduinoCoreCmd.AddCommand(arduinoCoreListCmd)
 	arduinoCoreCmd.AddCommand(arduinoCoreDownloadCmd)
+	arduinoCoreCmd.AddCommand(arduinoCoreVersionCmd)
 
 	arduinoCoreCmd.Flags().BoolVar(&arduinoCoreFlags.updateIndex, "update-index", false, "Updates the index of cores to the latest version")
 }

common/releases/helpers.go

@@ -72,7 +72,6 @@ func downloadRelease(item DownloadItem, progBar *pb.ProgressBar, label string) e
 		return fmt.Errorf("Cannot get Archive file of this release : %s", err)
 	}
 	defer initialData.Close()
-	fmt.Println(item.Release)
 	// puts the progress bar
 	err = common.DownloadPackage(item.Release.ArchiveURL(), initialData,
 		item.Release.ArchiveSize(), handleWithProgressBarFunc(progBar))

cores/cores.go

@@ -58,13 +58,14 @@ type Release struct {
 	Dependencies    ToolDependencies // The Dependency entries to load tools.
 }
 
-// ToolDependencies is a set of tuples representing summary data of a tool.
-type ToolDependencies []toolDependency
+// ToolDependencies is a set of tuples representing summary data of a tool dependency set.
+type ToolDependencies []*ToolDependency
 
-type toolDependency struct {
-	ToolPackager string
+// ToolDependency is a tuple representing summary data of a tool.
+type ToolDependency struct {
 	ToolName     string
 	ToolVersion  string
+	ToolPackager string
 }
 
 // GetVersion returns the specified release corresponding the provided version,

cores/index.go

@@ -69,7 +69,7 @@ type indexCoreRelease struct {
 	Size             int64                 `json:"size,required,string"`
 	Boards           []indexBoardRelease   `json:"boards"`
 	Help             indexHelpRelease      `json:"help,omitempty"`
-	ToolDependencies []indexToolDependency `json:"toolDependencies"`
+	ToolDependencies []indexToolDependency `json:"toolsDependencies, required"`
 }
 
 // indexToolDependency represents a single dependency of a core from a tool.
@@ -141,9 +141,22 @@ func (release indexCoreRelease) extractRelease() *Release {
 		Size:            release.Size,
 		URL:             release.URL,
 		Boards:          release.extractBoards(),
+		Dependencies:    release.extractDeps(),
 	}
 }
 
+func (release indexCoreRelease) extractDeps() ToolDependencies {
+	ret := make(ToolDependencies, len(release.ToolDependencies))
+	for i, dep := range release.ToolDependencies {
+		ret[i] = &ToolDependency{
+			ToolName:     dep.Name,
+			ToolVersion:  dep.Version,
+			ToolPackager: dep.Packager,
+		}
+	}
+	return ret
+}
+
 func (release indexCoreRelease) extractBoards() []string {
 	boards := make([]string, len(release.Boards))
 	for i, board := range release.Boards {

cores/status.go

@@ -73,7 +73,7 @@ func (sc StatusContext) Names() []string {
 	return res
 }
 
-func (tdep toolDependency) extractTool(sc StatusContext) (*Tool, error) {
+func (tdep ToolDependency) extractTool(sc StatusContext) (*Tool, error) {
 	pkg, exists := sc.Packages[tdep.ToolPackager]
 	if !exists {
 		return nil, errors.New("Package not found")
@@ -85,7 +85,7 @@ func (tdep toolDependency) extractTool(sc StatusContext) (*Tool, error) {
 	return tool, nil
 }
 
-func (tdep toolDependency) extractRelease(sc StatusContext) (*ToolRelease, error) {
+func (tdep ToolDependency) extractRelease(sc StatusContext) (*ToolRelease, error) {
 	tool, err := tdep.extractTool(sc)
 	if err != nil {
 		return nil, err
@@ -189,6 +189,5 @@ func (sc StatusContext) Process(items []CoreIDTuple) ([]releases.DownloadItem, [
 			})
 		}
 	}
-
 	return ret, fails
 }