Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Review our use of impl Stream in e.g. Match queries #21

Closed
alexjpwalker opened this issue Nov 21, 2022 · 1 comment
Closed

Review our use of impl Stream in e.g. Match queries #21

alexjpwalker opened this issue Nov 21, 2022 · 1 comment

Comments

@alexjpwalker
Copy link
Member

alexjpwalker commented Nov 21, 2022

Currently our Match queries return impl Stream<Item = ConceptMap>.

This becomes a particular problem in the Concept API. We want to define methods such as get_instances in a trait, but trait methods cannot return impl Stream.

It might be more useful to users if they knew the exact type of Stream. Trouble is, that type is a super-complex type.

We should investigate the performance impact of using BoxStream. If not, we may need to not define these methods in traits. It may be worth consulting the Rust API guidelines.

@flyingsilverfin
Copy link
Member

This is expected and we no longer use this API

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants