Skip to content

Commit c5488df

Browse files
authored
Fix CLI downgrade check (#1380)
* fix downgrade detection * remove unused semver package from webapp * add changeset
1 parent 1caec27 commit c5488df

File tree

5 files changed

+54
-69
lines changed

5 files changed

+54
-69
lines changed

.changeset/fuzzy-files-hunt.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"trigger.dev": patch
3+
---
4+
5+
Fix downgrade check by correctly comparing semvers

apps/webapp/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@
161161
"remix-typedjson": "0.3.1",
162162
"remix-utils": "^7.1.0",
163163
"seedrandom": "^3.0.5",
164-
"semver": "^7.5.0",
165164
"simple-oauth2": "^5.0.0",
166165
"simplur": "^3.0.1",
167166
"slug": "^6.0.0",
@@ -210,7 +209,6 @@
210209
"@types/react-dom": "18.2.7",
211210
"@types/regression": "^2.0.6",
212211
"@types/seedrandom": "^3.0.8",
213-
"@types/semver": "^7.3.13",
214212
"@types/simple-oauth2": "^5.0.4",
215213
"@types/slug": "^5.0.3",
216214
"@types/tar": "^6.1.4",

packages/cli-v3/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
"@types/react": "^18.2.48",
5353
"@types/resolve": "^1.20.6",
5454
"@types/rimraf": "^4.0.5",
55-
"@types/semver": "^7.3.13",
55+
"@types/semver": "^7.5.0",
5656
"@types/source-map-support": "0.5.10",
5757
"@types/ws": "^8.5.3",
5858
"cpy-cli": "^5.0.0",
@@ -112,6 +112,7 @@
112112
"partysocket": "^1.0.2",
113113
"pkg-types": "^1.1.3",
114114
"resolve": "^1.22.8",
115+
"semver": "^7.5.0",
115116
"signal-exit": "^4.1.0",
116117
"source-map-support": "0.5.21",
117118
"std-env": "^3.7.0",

packages/cli-v3/src/commands/update.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ import { spinner } from "../utilities/windows.js";
1313
import { VERSION } from "../version.js";
1414
import { hasTTY } from "std-env";
1515
import nodeResolve from "resolve";
16+
import * as semver from "semver";
1617

1718
export const UpdateCommandOptions = CommonCommandOptions.pick({
1819
logLevel: true,
@@ -112,7 +113,7 @@ export async function updateTriggerPackages(
112113
}
113114

114115
const isDowngrade = mismatches.some((dep) => {
115-
return dep.version > targetVersion;
116+
return semver.gt(dep.version, targetVersion);
116117
});
117118

118119
return {

0 commit comments

Comments
 (0)