Skip to content

Commit af8d979

Browse files
committed
Only show the catchError span if there are any catchError hooks
1 parent 020a752 commit af8d979

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

packages/core/src/v3/workers/taskExecutor.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1036,11 +1036,17 @@ export class TaskExecutor {
10361036
return { status: "skipped" };
10371037
}
10381038

1039+
const taskCatchErrorHook = lifecycleHooks.getTaskCatchErrorHook(this.task.id);
1040+
const globalCatchErrorHooks = lifecycleHooks.getGlobalCatchErrorHooks();
1041+
1042+
if (globalCatchErrorHooks.length === 0 && !taskCatchErrorHook) {
1043+
return { status: "noop" };
1044+
}
1045+
10391046
return this._tracer.startActiveSpan(
10401047
"catchError",
10411048
async (span) => {
10421049
// Try task-specific catch error hook first
1043-
const taskCatchErrorHook = lifecycleHooks.getTaskCatchErrorHook(this.task.id);
10441050
if (taskCatchErrorHook) {
10451051
const result = await taskCatchErrorHook({
10461052
payload,
@@ -1060,7 +1066,6 @@ export class TaskExecutor {
10601066
}
10611067

10621068
// Try global catch error hooks in order
1063-
const globalCatchErrorHooks = lifecycleHooks.getGlobalCatchErrorHooks();
10641069
for (const hook of globalCatchErrorHooks) {
10651070
const result = await hook.fn({
10661071
payload,

0 commit comments

Comments
 (0)