Skip to content

Commit 3c50bfe

Browse files
committed
Improvements to the runs replication service, now ready for testing
1 parent 955bc25 commit 3c50bfe

File tree

4 files changed

+118
-121
lines changed

4 files changed

+118
-121
lines changed

apps/webapp/app/env.server.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -765,6 +765,7 @@ const EnvironmentSchema = z.object({
765765
RUN_REPLICATION_LEADER_LOCK_TIMEOUT_MS: z.coerce.number().int().default(30_000),
766766
RUN_REPLICATION_LEADER_LOCK_EXTEND_INTERVAL_MS: z.coerce.number().int().default(10_000),
767767
RUN_REPLICATION_ACK_INTERVAL_SECONDS: z.coerce.number().int().default(10),
768+
RUN_REPLICATION_LOG_LEVEL: z.enum(["log", "error", "warn", "info", "debug"]).default("info"),
768769
});
769770

770771
export type Environment = z.infer<typeof EnvironmentSchema>;

apps/webapp/app/routes/admin.api.v1.runs-replication.start.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@ import { ActionFunctionArgs, json } from "@remix-run/server-runtime";
22
import { prisma } from "~/db.server";
33
import { authenticateApiRequestWithPersonalAccessToken } from "~/services/personalAccessToken.server";
44
import { runsReplicationInstance } from "~/services/runsReplicationInstance.server";
5-
import { z } from "zod";
6-
7-
const schema = z.object({
8-
insertStrategy: z.enum(["streaming", "batching"]).optional(),
9-
});
105

116
export async function action({ request }: ActionFunctionArgs) {
127
// Next authenticate the request
@@ -31,10 +26,7 @@ export async function action({ request }: ActionFunctionArgs) {
3126
}
3227

3328
try {
34-
const body = await request.json();
35-
const { insertStrategy } = schema.parse(body);
36-
37-
await runsReplicationInstance?.start(insertStrategy);
29+
await runsReplicationInstance?.start();
3830

3931
return json({
4032
success: true,

apps/webapp/app/services/runsReplicationInstance.server.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ function initializeRunsReplicationInstance() {
4646
leaderLockTimeoutMs: env.RUN_REPLICATION_LEADER_LOCK_TIMEOUT_MS,
4747
leaderLockExtendIntervalMs: env.RUN_REPLICATION_LEADER_LOCK_EXTEND_INTERVAL_MS,
4848
ackIntervalSeconds: env.RUN_REPLICATION_ACK_INTERVAL_SECONDS,
49+
logLevel: env.RUN_REPLICATION_LOG_LEVEL,
4950
});
5051

5152
if (env.RUN_REPLICATION_ENABLED === "1") {

0 commit comments

Comments
 (0)