Return the error responses. They were being caught and not preserved

matt-aitken · matt-aitken · commit 344dfdead41f · 2025-05-07T12:04:21.000+01:00
diff --git a/apps/webapp/app/routes/api.v1.waitpoints.http-callback.$waitpointFriendlyId.callback.$hash.ts b/apps/webapp/app/routes/api.v1.waitpoints.http-callback.$waitpointFriendlyId.callback.$hash.ts
@@ -45,11 +45,11 @@ export async function action({ request, params }: ActionFunctionArgs) {
     });
 
     if (!waitpoint) {
-      throw json({ error: "Waitpoint not found" }, { status: 404 });
+      return json({ error: "Waitpoint not found" }, { status: 404 });
     }
 
     if (!verifyHttpCallbackHash(waitpoint.id, hash, waitpoint.environment.apiKey)) {
-      throw json({ error: "Invalid URL, hash doesn't match" }, { status: 401 });
+      return json({ error: "Invalid URL, hash doesn't match" }, { status: 401 });
     }
 
     if (waitpoint.status === "COMPLETED") {

Original file line number	Diff line number	Diff line change
`@@ -45,11 +45,11 @@ export async function action({ request, params }: ActionFunctionArgs) {`
`45`	`45`	`});`
`46`	`46`
`47`	`47`	`if (!waitpoint) {`
`48`		`- throw json({ error: "Waitpoint not found" }, { status: 404 });`
	`48`	`+ return json({ error: "Waitpoint not found" }, { status: 404 });`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`if (!verifyHttpCallbackHash(waitpoint.id, hash, waitpoint.environment.apiKey)) {`
`52`		`- throw json({ error: "Invalid URL, hash doesn't match" }, { status: 401 });`
	`52`	`+ return json({ error: "Invalid URL, hash doesn't match" }, { status: 401 });`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`if (waitpoint.status === "COMPLETED") {`