fix(prefer-explicit-assert): allow object declarations

Author: afontcu

lib/rules/prefer-explicit-assert.js

@@ -1,13 +1,13 @@
 'use strict';
 
-const { getDocsUrl, ALL_QUERIES_METHODS } = require('../utils');
+const { findParent, getDocsUrl, ALL_QUERIES_METHODS } = require('../utils');
 
 const ALL_GET_BY_QUERIES = ALL_QUERIES_METHODS.map(
   queryMethod => `get${queryMethod}`
 );
 
 const findCallExpressionParent = node =>
-  node.type === 'CallExpression' ? node : findCallExpressionParent(node.parent);
+  findParent(node, node => node.type === 'CallExpression');
 
 const isValidQuery = (node, customQueryNames = []) =>
   ALL_GET_BY_QUERIES.includes(node.name) ||
@@ -19,14 +19,12 @@ const isDirectlyCalledByFunction = node =>
 const isReturnedByArrowFunctionExpression = node =>
   node.parent.type === 'ArrowFunctionExpression';
 
-const isDeclared = node => node.parent.type === 'VariableDeclarator';
+const isDeclared = node =>
+  !!findParent(node, node => node.type === 'VariableDeclarator');
 
 const isReturnedByReturnStatement = node =>
   node.parent.type === 'ReturnStatement';
 
-const isInsideArrayDeclaration = node =>
-  node.parent.parent.type === 'ArrayExpression';
-
 const isInDestructuringStatement = node =>
   (node.parent.type === 'Property' &&
     node.parent.parent.type === 'ObjectPattern') ||
@@ -72,7 +70,6 @@ module.exports = {
         if (
           isValidQuery(node, customQueryNames) &&
           !isInDestructuringStatement(node) &&
-          !isInsideArrayDeclaration(node) &&
           !isDirectlyCalledByFunction(callExpressionNode) &&
           !isReturnedByArrowFunctionExpression(callExpressionNode) &&
           !isDeclared(callExpressionNode) &&

lib/utils.js

@@ -48,7 +48,18 @@ const ALL_QUERIES_COMBINATIONS = [
   ASYNC_QUERIES_COMBINATIONS,
 ];
 
+const findParent = (node, cb) => {
+  if (cb(node)) {
+    return node;
+  } else if (node.parent) {
+    return findParent(node.parent, cb);
+  } else {
+    return null;
+  }
+};
+
 module.exports = {
+  findParent,
   getDocsUrl,
   SYNC_QUERIES_VARIANTS,
   ASYNC_QUERIES_VARIANTS,

tests/lib/rules/prefer-explicit-assert.js

@@ -62,6 +62,9 @@ ruleTester.run('prefer-explicit-assert', rule, {
     {
       code: `const a = [ getByText('foo') ]`,
     },
+    {
+      code: `const a = { foo: getByText('bar') }`,
+    },
   ],
 
   invalid: [