Skip to content

Commit 685e443

Browse files
committed
code health: unify messages format in datetime
After the patch all messages in datetime tests start with a capital letter. All errors start with a lowecase letter [1]. 1. https://github.com/golang/go/wiki/CodeReviewComments#error-strings
1 parent f5cbb11 commit 685e443

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

datetime/datetime.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ func NewDatetime(t time.Time) (*Datetime, error) {
8686
seconds := t.Unix()
8787

8888
if seconds < minSeconds || seconds > maxSeconds {
89-
return nil, fmt.Errorf("Time %s is out of supported range.", t)
89+
return nil, fmt.Errorf("time %s is out of supported range", t)
9090
}
9191

9292
dt := new(Datetime)

datetime/datetime_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ func (t *Tuple1) DecodeMsgpack(d *decoder) error {
286286
return err
287287
}
288288
if l != 1 {
289-
return fmt.Errorf("array len doesn't match: %d", l)
289+
return fmt.Errorf("Array len doesn't match: %d", l)
290290
}
291291
err = d.Decode(&t.Datetime)
292292
if err != nil {
@@ -315,7 +315,7 @@ func (ev *Event) DecodeMsgpack(d *decoder) error {
315315
return err
316316
}
317317
if l != 2 {
318-
return fmt.Errorf("array len doesn't match: %d", l)
318+
return fmt.Errorf("Array len doesn't match: %d", l)
319319
}
320320
if ev.Location, err = d.DecodeString(); err != nil {
321321
return err
@@ -326,7 +326,7 @@ func (ev *Event) DecodeMsgpack(d *decoder) error {
326326
}
327327
var ok bool
328328
if ev.Datetime, ok = toDatetime(res); !ok {
329-
return fmt.Errorf("datetime doesn't match")
329+
return fmt.Errorf("Datetime doesn't match")
330330
}
331331
return nil
332332
}
@@ -352,7 +352,7 @@ func (c *Tuple2) DecodeMsgpack(d *decoder) error {
352352
return err
353353
}
354354
if l != 3 {
355-
return fmt.Errorf("array len doesn't match: %d", l)
355+
return fmt.Errorf("Array len doesn't match: %d", l)
356356
}
357357
if c.Cid, err = d.DecodeUint(); err != nil {
358358
return err

datetime/example_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ func Example() {
2525
}
2626
conn, err := tarantool.Connect("127.0.0.1:3013", opts)
2727
if err != nil {
28-
fmt.Printf("error in connect is %v", err)
28+
fmt.Printf("Error in connect is %v", err)
2929
return
3030
}
3131

3232
var datetime = "2013-10-28T17:51:56.000000009Z"
3333
tm, err := time.Parse(time.RFC3339, datetime)
3434
if err != nil {
35-
fmt.Printf("error in time.Parse() is %v", err)
35+
fmt.Printf("Error in time.Parse() is %v", err)
3636
return
3737
}
3838
dt, err := NewDatetime(tm)
@@ -47,7 +47,7 @@ func Example() {
4747
// Replace a tuple with datetime.
4848
resp, err := conn.Replace(space, []interface{}{dt})
4949
if err != nil {
50-
fmt.Printf("error in replace is %v", err)
50+
fmt.Printf("Error in replace is %v", err)
5151
return
5252
}
5353
respDt := resp.Data[0].([]interface{})[0].(Datetime)
@@ -60,7 +60,7 @@ func Example() {
6060
var limit uint32 = 1
6161
resp, err = conn.Select(space, index, offset, limit, tarantool.IterEq, []interface{}{dt})
6262
if err != nil {
63-
fmt.Printf("error in select is %v", err)
63+
fmt.Printf("Error in select is %v", err)
6464
return
6565
}
6666
respDt = resp.Data[0].([]interface{})[0].(Datetime)
@@ -71,7 +71,7 @@ func Example() {
7171
// Delete a tuple with datetime.
7272
resp, err = conn.Delete(space, index, []interface{}{dt})
7373
if err != nil {
74-
fmt.Printf("error in delete is %v", err)
74+
fmt.Printf("Error in delete is %v", err)
7575
return
7676
}
7777
respDt = resp.Data[0].([]interface{})[0].(Datetime)

0 commit comments

Comments
 (0)