[cmake] Link socket/nsl on SunOS in llvm-jitlink

nikic · nikic · commit f111dc7cfcda · 2021-03-09T19:04:59.000+01:00
llvm-jitlink and llvm-jitlink-executor make use of APIs that are part of the socket and nsl libraries on SunOS systems (Solaris and Illumos). Make sure they get linked. Ran into this in Rust CI when cross-compiling LLVM 12 to these targets. Differential Revision: https://reviews.llvm.org/D97633
diff --git a/llvm/tools/llvm-jitlink/CMakeLists.txt b/llvm/tools/llvm-jitlink/CMakeLists.txt
@@ -24,4 +24,8 @@ add_llvm_tool(llvm-jitlink
   llvm-jitlink-macho.cpp
   )
 
+if(${CMAKE_SYSTEM_NAME} MATCHES "SunOS")
+  target_link_libraries(llvm-jitlink PRIVATE socket nsl)
+endif()
+
 export_executable_symbols(llvm-jitlink)
diff --git a/llvm/tools/llvm-jitlink/llvm-jitlink-executor/CMakeLists.txt b/llvm/tools/llvm-jitlink/llvm-jitlink-executor/CMakeLists.txt
@@ -11,4 +11,8 @@ add_llvm_utility(llvm-jitlink-executor
   intrinsics_gen
 )
 
+if(${CMAKE_SYSTEM_NAME} MATCHES "SunOS")
+  target_link_libraries(llvm-jitlink-executor PRIVATE socket)
+endif()
+
 export_executable_symbols(llvm-jitlink-executor)

Original file line number	Diff line number	Diff line change
`@@ -24,4 +24,8 @@ add_llvm_tool(llvm-jitlink`
`24`	`24`	`llvm-jitlink-macho.cpp`
`25`	`25`	`)`
`26`	`26`
	`27`	`+if(${CMAKE_SYSTEM_NAME} MATCHES "SunOS")`
	`28`	`+ target_link_libraries(llvm-jitlink PRIVATE socket nsl)`
	`29`	`+endif()`
	`30`	`+`
`27`	`31`	`export_executable_symbols(llvm-jitlink)`
Original file line number	Diff line number	Diff line change
`@@ -11,4 +11,8 @@ add_llvm_utility(llvm-jitlink-executor`
`11`	`11`	`intrinsics_gen`
`12`	`12`	`)`
`13`	`13`
	`14`	`+if(${CMAKE_SYSTEM_NAME} MATCHES "SunOS")`
	`15`	`+ target_link_libraries(llvm-jitlink-executor PRIVATE socket)`
	`16`	`+endif()`
	`17`	`+`
`14`	`18`	`export_executable_symbols(llvm-jitlink-executor)`