fix: support all call signatures

Author: 43081j

packages/eslint-plugin-svelte/src/rules/no-add-event-listener.ts

@@ -29,10 +29,6 @@ export default createRule('no-add-event-listener', {
 				const { callee, arguments: args } = node;
 				let target: string | null = null;
 
-				if (args.length < 2 || args.length > 3) {
-					return;
-				}
-
 				if (
 					callee.type === 'MemberExpression' &&
 					callee.property.type === 'Identifier' &&

packages/eslint-plugin-svelte/tests/fixtures/rules/no-add-event-listener/invalid/test01-errors.yaml

@@ -36,6 +36,9 @@
 
         	// with options
         	window.addEventListener('message', handler, { once: true });
+
+        	// using spread
+        	window.addEventListener(...params);
         </script>
 
         <button onclick={onClick}>Hello</button>
@@ -77,6 +80,9 @@
 
         	// with options
         	window.addEventListener('message', handler, { once: true });
+
+        	// using spread
+        	window.addEventListener(...params);
         </script>
 
         <button onclick={onClick}>Hello</button>
@@ -118,6 +124,9 @@
 
         	// with options
         	window.addEventListener('message', handler, { once: true });
+
+        	// using spread
+        	window.addEventListener(...params);
         </script>
 
         <button onclick={onClick}>Hello</button>
@@ -159,6 +168,9 @@
 
         	// with options
         	window.addEventListener('message', handler, { once: true });
+
+        	// using spread
+        	window.addEventListener(...params);
         </script>
 
         <button onclick={onClick}>Hello</button>
@@ -200,6 +212,9 @@
 
         	// with options
         	window.addEventListener('message', handler, { once: true });
+
+        	// using spread
+        	window.addEventListener(...params);
         </script>
 
         <button onclick={onClick}>Hello</button>
@@ -241,6 +256,9 @@
 
         	// with options
         	window.addEventListener('message', handler, { once: true });
+
+        	// using spread
+        	window.addEventListener(...params);
         </script>
 
         <button onclick={onClick}>Hello</button>
@@ -282,6 +300,9 @@
 
         	// with options
         	window.addEventListener('message', handler, { once: true });
+
+        	// using spread
+        	window.addEventListener(...params);
         </script>
 
         <button onclick={onClick}>Hello</button>
@@ -323,6 +344,53 @@
 
         	// with options
         	on(window, 'message', handler, { once: true });
+
+        	// using spread
+        	window.addEventListener(...params);
+        </script>
+
+        <button onclick={onClick}>Hello</button>
+- message: Do not use `addEventListener`. Use the `on` function from
+    `svelte/events` instead.
+  line: 34
+  column: 2
+  suggestions:
+    - desc: Use `on` from `svelte/events` instead
+      output: |
+        <script>
+        	const handler = (ev) => {
+        		console.log(ev);
+        	};
+
+        	function onClick(event) {
+        		const target = event.currentTarget;
+
+        		const deepObj = {
+        			deep: {
+        				obj: {
+        					target
+        				}
+        			}
+        		};
+
+        		target.addEventListener('focus', handler);
+        		deepObj.deep.obj.target.addEventListener('focus', handler);
+        	}
+
+        	addEventListener('message', handler);
+        	window.addEventListener('message', handler);
+        	document.addEventListener('visibilitychange', handler);
+
+        	// with a load of whitespace
+        	window.addEventListener    ('message', handler);
+        	// with a comment
+        	window.addEventListener/* foo */('message', handler);
+
+        	// with options
+        	window.addEventListener('message', handler, { once: true });
+
+        	// using spread
+        	on(window, ...params);
         </script>
 
         <button onclick={onClick}>Hello</button>

packages/eslint-plugin-svelte/tests/fixtures/rules/no-add-event-listener/invalid/test01-input.svelte

@@ -29,6 +29,9 @@
 
 	// with options
 	window.addEventListener('message', handler, { once: true });
+
+	// using spread
+	window.addEventListener(...params);
 </script>
 
 <button onclick={onClick}>Hello</button>