Skip to content

Product image selection should only include a slash after the repo if needed #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
lfrancke opened this issue Apr 29, 2025 · 0 comments
Open
2 tasks

Comments

@lfrancke
Copy link
Member

Currently a slash is always appended to the repo.

let image = format!("{repo}/{image_base_name}:{product_version}-stackable{stackable_version}",);

While it will probably work if users add a / themselves to the repo it would not be unheard of to cause trouble.
We should therefore only conditionally append the slash.

This behavior is documented in our docs and references this issue so as part of fixing this issue those docs need to be adjusted as well.

  • Slash is only appended when repo does not already end with a slash
  • Documentation is updated to remove the reference to this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant