Skip to content

Build fails #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GerardRodes opened this issue Aug 9, 2023 · 3 comments
Closed

Build fails #2591

GerardRodes opened this issue Aug 9, 2023 · 3 comments
Labels
bug Something isn't working triage New issues that hasn't been reviewed
Milestone

Comments

@GerardRodes
Copy link

Version

1.20.0

What happened?

Build is failing, updating pg_query_go should fix it

Related: pganalyze/pg_query_go#96

Relevant log output

❯ go install github.com/sqlc-dev/sqlc/cmd/sqlc@latest  
# github.com/pganalyze/pg_query_go/v4/parser
src_port_snprintf.c:374:1: error: conflicting types for ‘strchrnul’; have ‘const char *(const char *, int)’
  374 | strchrnul(const char *s, int c)
      | ^~~~~~~~~
In file included from ../../.gvm/pkgsets/go1.21/global/pkg/mod/github.com/pganalyze/pg_query_go/[email protected]/parser/include/c.h:61,
                 from src_port_snprintf.c:62:
/usr/include/string.h:286:14: note: previous declaration of ‘strchrnul’ with type ‘char *(const char *, int)’
  286 | extern char *strchrnul (const char *__s, int __c)
      |              ^~~~~~~~~
cc1: note: unrecognized command-line option ‘-Wno-unknown-warning-option’ may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option ‘-Wno-deprecated-non-prototype’ may have been intended to silence earlier diagnostics

Database schema

No response

SQL queries

No response

Configuration

No response

Playground URL

No response

What operating system are you using?

Linux

What database engines are you using?

No response

What type of code are you generating?

No response

@GerardRodes GerardRodes added bug Something isn't working triage New issues that hasn't been reviewed labels Aug 9, 2023
@mvdan
Copy link

mvdan commented Aug 9, 2023

Yep, see pganalyze/pg_query_go#95. sqlc should bump the dependency and probably tag a release.

@blizzy78
Copy link

The relevant PR should be #2583.

@kyleconroy kyleconroy modified the milestones: v1.20.0, 1.21.0 Aug 28, 2023
@kyleconroy
Copy link
Collaborator

This has been fixed on main and will be included in sqlc 1.21, which will be released on 9/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage New issues that hasn't been reviewed
Projects
None yet
Development

No branches or pull requests

4 participants