Skip to content

Go renames don't work in config v2 #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
josharian opened this issue Dec 1, 2022 · 1 comment
Closed

Go renames don't work in config v2 #1977

josharian opened this issue Dec 1, 2022 · 1 comment
Labels
bug Something isn't working triage New issues that hasn't been reviewed

Comments

@josharian
Copy link
Contributor

Version

1.15.0

What happened?

[I'm actually running 1.16.0, but the dropdown is missing that choice.]

I tried porting my config file from v1 to v2. Go renames and overrides stopped working.

To confirm that I didn't just make a config file mistake, I instrumented v2ParseConfig. I can confirm that my requested renames and overrides are present in the config field conf.SQL[0].Gen.Go (per the docs), but the downstream code is reading the configs from conf.Gen.Go, including later in v2ParseConfig.

Relevant log output

No response

Database schema

No response

SQL queries

No response

Configuration

No response

Playground URL

No response

What operating system are you using?

No response

What database engines are you using?

No response

What type of code are you generating?

Go

@josharian josharian added bug Something isn't working triage New issues that hasn't been reviewed labels Dec 1, 2022
@Emyrk
Copy link
Contributor

Emyrk commented Jan 23, 2023

My PR should fix this: #2001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage New issues that hasn't been reviewed
Projects
None yet
Development

No branches or pull requests

3 participants