Skip to content

Commit f514135

Browse files
feat(postgresql): Support system columns on tables (#2871)
* test: Add a test case for #1745 * feat(postgresql): Support system columns * Remove stdlib * Update sqlc.yaml * Add exec.json --------- Co-authored-by: Andrew Benton <[email protected]>
1 parent 5ddc461 commit f514135

File tree

9 files changed

+108
-1
lines changed

9 files changed

+108
-1
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
https://github.com/sqlc-dev/sqlc/issues/1745
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"contexts": ["managed-db"]
3+
}

internal/endtoend/testdata/select_system/pgx/go/db.go

Lines changed: 32 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/select_system/pgx/go/models.go

Lines changed: 13 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/endtoend/testdata/select_system/pgx/go/query.sql.go

Lines changed: 41 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
-- name: GetSystemColumns :one
2+
SELECT
3+
tableoid, xmin, cmin, xmax, cmax, ctid
4+
FROM test;
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
CREATE TABLE test (
2+
id INT
3+
);
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
version: "2"
2+
sql:
3+
- engine: "postgresql"
4+
schema: "schema.sql"
5+
queries: "query.sql"
6+
gen:
7+
go:
8+
package: "querytest"
9+
out: "go"
10+
sql_package: "pgx/v5"

internal/engine/postgresql/analyzer/analyze.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ func (a *Analyzer) columnInfo(ctx context.Context, field pgconn.FieldDescription
101101
if ok {
102102
return cinfo.(*pgColumn), nil
103103
}
104-
rows, err := a.pool.Query(ctx, columnQuery, field.TableOID, field.TableAttributeNumber)
104+
rows, err := a.pool.Query(ctx, columnQuery, field.TableOID, int16(field.TableAttributeNumber))
105105
if err != nil {
106106
return nil, err
107107
}

0 commit comments

Comments
 (0)