-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Bump default BCrypt strength to 12 #10447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ty into feature/bcrypt/12
Thanks for the PR, @larsgrefer. Based on OWASP/CheatSheetSeries#601 it seems like OWASP continues to recommend 10 as the minimum work factor. I lean towards sticking with OWASP's recommendations - why do you think it should be increased to 12? |
In my opinion, 10 is way too fast for any near-modern hardware. See #7411 (comment) for some numbers. The Spring Security documentation itself states:
With below 100ms, 10 is nearly two orders of magnitude too fast. Also the current default of 10 was not adjusted since 8565116 10 years ago. With the concerns you mentioned in #7411 (comment) in mind I'd recommend to bump it "only" to 12 for Spring Security 5.x and then bump it to 13 for 6.x |
Just had a look and you should be more worried about increasing the defaults for Argon2, scrypt, and PBKDF2. Since those don't even meet the bare minimum settings. Also there's a bug in PBKDF2's defaults. Argon2's setting are Anyway those are just the bare minimums. |
PBKDF2's bug reported here: #10489 |
@larsgrefer, I appreciate the research you've done here. I'd like to adhere to the OWASP password recommendations since they are a single reliable source we can use for decision making. If 10 is too low, let's start with OWASP to get their recommendation increased to 12. |
@jzheaux OWASP explicitly asked Spring Security to use a strength of 12: OWASP/CheatSheetSeries#601 (comment) |
see #7411