Skip to content

Remove OpenSamlImplementation #8775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
jzheaux opened this issue Jun 29, 2020 · 0 comments
Closed
3 tasks done

Remove OpenSamlImplementation #8775

jzheaux opened this issue Jun 29, 2020 · 0 comments
Assignees
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jun 29, 2020

OpenSamlImplementation is a package-private Spring Security class that exists to remove some of the boilerplate needed to configure and work with OpenSAML.

In effect, it does four things:

  • Bootstraps OpenSAML with reasonable defaults
  • Builds OpenSAML XMLObjects
  • Marshals OpenSAML XMLObjects
  • Unmarshals OpenSAML XMLObjects

While it was convenient to have in the early stages of creating saml2-service-provider, there's value in breaking it up into its individual components.

The above plan requires minimal code duplication as the authentication provider is largely unmarshalling objects while the authentication request factory is marshalling them. Additionally, the marshalling support in OpenSamlImplementation is largely specific to AuthnRequest.

@jzheaux jzheaux added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules labels Jun 29, 2020
@jzheaux jzheaux added this to the 5.4.0-RC1 milestone Jun 29, 2020
@jzheaux jzheaux self-assigned this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant