Skip to content

Typo in title of SAML2 Sample Readme #8562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sgilson opened this issue May 19, 2020 · 5 comments
Closed

Typo in title of SAML2 Sample Readme #8562

sgilson opened this issue May 19, 2020 · 5 comments
Assignees
@rwinch
Labels
in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: enhancement A general enhancement

Comments

@sgilson
Copy link
Contributor

sgilson commented May 19, 2020

The title of the file samples/boot/saml2login/README.adoc is currently "OAuth 2.0 Login Sample". It should be "SAML 2.0 Login Sample".
@sgilson sgilson added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels May 19, 2020
@sgilson sgilson changed the title Type in title of SAML2 Sample Readme Typo in title of SAML2 Sample Readme May 19, 2020
@rwinch
Copy link
Member

rwinch commented May 21, 2020

Thanks for the report. I saw you sent a pull request at #8561 but you delete the branch. Any particular reason you did that? Would you be interested in submitting a pull request?

@rwinch rwinch added in: docs An issue in Documentation or samples status: ideal-for-contribution An issue that we actively are looking for someone to help us with and removed status: waiting-for-triage An issue we've not yet triaged labels May 21, 2020
@sgilson
Copy link
Contributor Author

sgilson commented May 21, 2020

Hi @rwinch , thanks for the response. After I submitted the PR, I realized I wasn't in a position to sign the Contributor License Agreement quite yet. I wasn't exactly sure what the right course of action was.

@rwinch
Copy link
Member

rwinch commented May 21, 2020

Thanks for the fast response. Please feel free to resubmit and indicate it as an obvious fix using @pivotal-issuemaster This is an Obvious Fix That will make the bot happy.

@sgilson
Copy link
Contributor Author

sgilson commented May 22, 2020

Terrific. Reopened at #8581

@rwinch rwinch self-assigned this May 27, 2020
@rwinch rwinch added status: duplicate A duplicate of another issue and removed status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels May 27, 2020
@rwinch
Copy link
Member

rwinch commented May 27, 2020

Closing in favour of gh-8581

@rwinch rwinch closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwinch @sgilson