Skip to content

Unused field in Md4PasswordEncoder #8537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justmehyp opened this issue May 16, 2020 · 4 comments
Closed

Unused field in Md4PasswordEncoder #8537

justmehyp opened this issue May 16, 2020 · 4 comments
Assignees
@rwinch
Labels
in: crypto An issue in spring-security-crypto status: duplicate A duplicate of another issue type: bug A general bug

Comments

@justmehyp
Copy link
Contributor

It seems that the following line in Md4PasswordEncoder is redundant:

spring-security/crypto/src/main/java/org/springframework/security/crypto/password/Md4PasswordEncoder.java

Line 86 in 1e211b6

private Digester digester;

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 16, 2020
@rwinch
Copy link
Member

rwinch commented May 18, 2020

It is not clear to me what you mean. Can you provide more details?

@rwinch rwinch added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels May 18, 2020
@justmehyp
Copy link
Contributor Author

justmehyp commented May 19, 2020 •
edited
Loading

@rwinch Sorry that I didn't make it clear at one time. When I read the source code of class org.springframework.security.crypto.password.Md4PasswordEncoder, I guessed that it was implemented by org.springframework.security.crypto.password.Digester, but I found that private Digester digester; was defined in class Md4PasswordEncoder, but it was never used. So I think this line of code is redundant, and could be removed.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 19, 2020
@justmehyp
Copy link
Contributor Author

This is my PR related to this issue: #8553

@justmehyp justmehyp changed the title Redundant code in Md4PasswordEncoder Unused field in Md4PasswordEncoder May 19, 2020
@rwinch rwinch self-assigned this May 21, 2020
@rwinch rwinch added in: crypto An issue in spring-security-crypto type: bug A general bug status: duplicate A duplicate of another issue and removed status: feedback-provided Feedback has been provided labels May 21, 2020
@rwinch
Copy link
Member

rwinch commented May 21, 2020

Thanks for the PR! I'm closing this a duplicate of the PR

@rwinch rwinch closed this as completed May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: crypto An issue in spring-security-crypto status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwinch @spring-projects-issues @justmehyp