Skip to content

OpenSamlAuthenticationProvider should propagate validation errors #7376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Sep 5, 2019 · 1 comment
Closed

OpenSamlAuthenticationProvider should propagate validation errors #7376

rwinch opened this issue Sep 5, 2019 · 1 comment
Labels
in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: bug A general bug
Milestone
5.2.0

Comments

@rwinch
Copy link
Member

rwinch commented Sep 5, 2019

Summary

Currently OpenSamlAuthenticationProvider swallows errors and just returns true or false. It should propagate the errors
@rwinch rwinch added in: saml2 An issue in SAML2 modules type: bug A general bug labels Sep 5, 2019
@rwinch rwinch added this to the 5.2.0 milestone Sep 5, 2019
@fhanik fhanik added the status: duplicate A duplicate of another issue label Sep 6, 2019
@fhanik
Copy link
Contributor

fhanik commented Sep 6, 2019

Duplicate of #7375

@fhanik fhanik marked this as a duplicate of #7375 Sep 6, 2019
@fhanik fhanik closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
2 participants
@rwinch @fhanik