Skip to content

SEC-3106: Option in BasicAuthenticationFilter to log more exception info #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Sep 16, 2015 · 1 comment
Closed

SEC-3106: Option in BasicAuthenticationFilter to log more exception info #3308

spring-projects-issues opened this issue Sep 16, 2015 · 1 comment
Assignees
@eleftherias
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement type: jira An issue that was migrated from JIRA
Milestone
5.3.0.M1

Comments

@spring-projects-issues
Copy link

Bill Chen (Migrated from SEC-3106) said:

The current code in doFilterInternal() logs in this way:

logger.debug("Authentication request for failed: " + failed);

which, in most cases just produces: "Authentication request for failed: org.springframework.security.authentication.BadCredentialsException: Bad credentials". This is neither a correct sentence nor useful for debugging.

Could it be changed so it logs the stack at trace level or something?
@spring-projects-issues spring-projects-issues added in: web An issue in web modules (web, webmvc) Open type: enhancement A general enhancement type: jira An issue that was migrated from JIRA labels Feb 5, 2016
@spring-projects-issues spring-projects-issues added this to the 4.1.0 M1 milestone Feb 5, 2016
@rwinch rwinch modified the milestones: 4.1.0 RC1, 4.0 Backlog Mar 22, 2016
@rwinch rwinch modified the milestone: 4.0 Backlog Aug 15, 2016
@rwinch rwinch removed the Open label May 3, 2019
@eleftherias eleftherias self-assigned this Nov 27, 2019
@eleftherias
Copy link
Contributor

Fixed via gh-7678

@eleftherias eleftherias added this to the 5.3.0.M1 milestone Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleftherias eleftherias

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement type: jira An issue that was migrated from JIRA
Projects
None yet
Milestone
5.3.0.M1
Development

No branches or pull requests
3 participants
@rwinch @eleftherias @spring-projects-issues