You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
In commit 7288fec the assertion on the input to check if the input was a valid ip was "fixed" to make it more complete, unfortunately the additional checks significantly increase CPU time which was unexpected.
It seems that the new assertions are more computationally expensive than the actual matching code.
To Reproduce
Run sample below for a basic test showing the difference is performance
Expected behavior
No significant performance regressions
Thanks for the report, @Mnkras. I've made some performance improvements. On my machine, the ratio drops from ~500 to ~10. Can you please try the 6.3.2-SNAPSHOT and let me know?
Uh oh!
There was an error while loading. Please reload this page.
Describe the bug
In commit 7288fec the assertion on the input to check if the input was a valid ip was "fixed" to make it more complete, unfortunately the additional checks significantly increase CPU time which was unexpected.
It seems that the new assertions are more computationally expensive than the actual matching code.
To Reproduce
Run sample below for a basic test showing the difference is performance
Expected behavior
No significant performance regressions
Sample
(https://gist.github.com/Mnkras/b02bd4e68cc4455d1aed6b2dde8c411f)
@jzheaux FYI
The text was updated successfully, but these errors were encountered: