Skip to content

Cookie no support for field 'version' and 'comment' #12454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
twosom opened this issue Dec 23, 2022 · 0 comments
Closed

Cookie no support for field 'version' and 'comment' #12454

twosom opened this issue Dec 23, 2022 · 0 comments
Assignees
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone

Comments

@twosom
Copy link
Contributor

twosom commented Dec 23, 2022

Expected Behavior

jakarta.servlet.http.Cookie now support RFC 6265.

and getComment, setComment, getVersion, setVersion
With the adoption of support for RFC 6265, those method should no longer be used.

and now, those methods's body is empty or return null.
therefore, we should add @Deprecated on SavedCookie.class's constructor and some getter.

Current Behavior

in getter, it always return 0 or null. and setter have no operation.

Context
Suggested solution: #12531

@twosom twosom added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Dec 23, 2022
@twosom twosom changed the title Cookie doesn Cookie no support for field 'version' and 'comment' Dec 23, 2022
@jzheaux jzheaux self-assigned this Jan 4, 2023
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 4, 2023
@jzheaux jzheaux added this to the 6.1.0-M1 milestone Jan 4, 2023
@marcusdacoregio marcusdacoregio modified the milestones: 6.1.0-M1, 6.1.0-M2 Jan 16, 2023
twosom added a commit to twosom/spring-security that referenced this issue Jan 18, 2023
@jzheaux jzheaux closed this as completed in 073dab3 Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants