Skip to content

Wrong name of the filter in the SecurityContextHolderFilter diagram #11800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
underground-hill opened this issue Sep 9, 2022 · 3 comments
Closed
Assignees
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Milestone

Comments

@underground-hill
Copy link
Contributor

Hi,

diagram related to SecurityContextHolderFilter is referring to SecurityContextPersistenceFilter instead of SecurityContextHolderFilter in documentation:

https://docs.spring.io/spring-security/reference/5.7.0/servlet/authentication/persistence.html#securitycontextholderfilter

which got me a little bit confused.

This is present from 5.7.x onward.

@underground-hill underground-hill added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Sep 9, 2022
@sjohnr
Copy link
Contributor

sjohnr commented Sep 9, 2022

Thanks @underground-hill. There is a new property introduced in 5.7, http.securityContext().requireExplicitSave(true) that will align you with what is coming in 6.0. In 5.7 it's defaulted to false, I believe, and in 6.0 it should (or will) be defaulted to true.

So in 6.0, I believe the diagram would indeed benefit from changing. Does that sound accurate based on what you're seeing?

@sjohnr sjohnr added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Sep 9, 2022
@sjohnr sjohnr added this to the 6.0.x milestone Sep 9, 2022
@underground-hill
Copy link
Contributor Author

Hi @sjohnr,

thank you for your reply! What I had in mind was this diagram:

https://docs.spring.io/spring-security/reference/5.7.0/_images/servlet/authentication/securitycontextholderfilter.png

where SecurityContextPersistenceFilter is mentioned twice, and I think it should be SecurityContextHolderFilter (because this is section about it, and not the persistence filter).

I should have pointed to the diagram in the first post, sorry for the confusion!

@sjohnr
Copy link
Contributor

sjohnr commented Sep 12, 2022

Oh, I see. Thanks for clarifying @underground-hill!

@jzheaux jzheaux modified the milestones: 6.0.x, 5.7.7 Jan 11, 2023
@jzheaux jzheaux self-assigned this Jan 11, 2023
@jzheaux jzheaux added type: bug A general bug and removed type: enhancement A general enhancement labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants