Use try-with-resources instead of try-finally

Author: larsgrefer

config/src/integration-test/java/org/springframework/security/config/ldap/LdapServerBeanDefinitionParserTests.java

@@ -99,17 +99,8 @@ public void defaultLdifFileIsSuccessful() {
 	}
 
 	private int getDefaultPort() throws IOException {
-		ServerSocket server = null;
-		try {
-			server = new ServerSocket(0);
+		try (ServerSocket server = new ServerSocket(0)) {
 			return server.getLocalPort();
 		}
-		finally {
-			try {
-				server.close();
-			}
-			catch (IOException e) {
-			}
-		}
 	}
 }

core/src/test/java/org/springframework/security/core/JavaVersionTests.java

@@ -38,21 +38,13 @@ public void authenticationCorrectJdkCompatibility() throws Exception {
 
 	private void assertClassVersion(Class<?> clazz) throws Exception {
 		String classResourceName = clazz.getName().replaceAll("\\.", "/") + ".class";
-		InputStream input = Thread.currentThread().getContextClassLoader()
-				.getResourceAsStream(classResourceName);
-		try {
+		try (InputStream input = Thread.currentThread().getContextClassLoader()
+				.getResourceAsStream(classResourceName)) {
 			DataInputStream data = new DataInputStream(input);
 			data.readInt();
 			data.readShort(); // minor
 			int major = data.readShort();
 			assertThat(major).isEqualTo(JDK8_CLASS_VERSION);
 		}
-		finally {
-			try {
-				input.close();
-			}
-			catch (Exception e) {
-			}
-		}
 	}
 }

ldap/src/integration-test/java/org/springframework/security/ldap/ApacheDSServerIntegrationTests.java

@@ -114,19 +114,8 @@ public static int getServerPort() {
 	 */
 
 	private static int getAvailablePort() throws IOException {
-		ServerSocket serverSocket = null;
-		try {
-			serverSocket = new ServerSocket(0);
+		try (ServerSocket serverSocket = new ServerSocket(0)) {
 			return serverSocket.getLocalPort();
 		}
-		finally {
-			if (serverSocket != null) {
-				try {
-					serverSocket.close();
-				}
-				catch (IOException e) {
-				}
-			}
-		}
 	}
 }