11/*
2- * Copyright 2002-2016 the original author or authors.
2+ * Copyright 2002-2018 the original author or authors.
33 *
44 * Licensed under the Apache License, Version 2.0 (the "License");
55 * you may not use this file except in compliance with the License.
1515 */
1616package org .springframework .security .acls .jdbc ;
1717
18- import static org .mockito .ArgumentMatchers .anyList ;
19- import static org .mockito .Mockito .when ;
20-
21- import java .util .Arrays ;
22- import java .util .HashMap ;
23- import java .util .List ;
24- import java .util .Map ;
25-
26- import javax .sql .DataSource ;
27-
18+ import org .junit .After ;
2819import org .junit .Before ;
2920import org .junit .Test ;
3021import org .junit .runner .RunWith ;
3122import org .mockito .Mock ;
3223import org .mockito .junit .MockitoJUnitRunner ;
24+ import org .springframework .jdbc .core .JdbcOperations ;
25+ import org .springframework .jdbc .core .RowMapper ;
26+ import org .springframework .jdbc .datasource .embedded .EmbeddedDatabase ;
27+ import org .springframework .jdbc .datasource .embedded .EmbeddedDatabaseBuilder ;
3328import org .springframework .security .acls .domain .ObjectIdentityImpl ;
3429import org .springframework .security .acls .domain .PrincipalSid ;
3530import org .springframework .security .acls .model .Acl ;
3631import org .springframework .security .acls .model .NotFoundException ;
3732import org .springframework .security .acls .model .ObjectIdentity ;
3833import org .springframework .security .acls .model .Sid ;
3934
35+ import javax .sql .DataSource ;
36+ import java .util .*;
37+
38+ import static org .assertj .core .api .Assertions .assertThat ;
39+ import static org .mockito .AdditionalMatchers .aryEq ;
40+ import static org .mockito .ArgumentMatchers .*;
41+ import static org .mockito .Mockito .when ;
42+
43+ /**
44+ * Unit and Integration tests the ACL JdbcAclService using an
45+ * in-memory database.
46+ *
47+ * @author Nena Raab
48+ */
4049@ RunWith (MockitoJUnitRunner .class )
4150public class JdbcAclServiceTests {
51+
52+ private EmbeddedDatabase embeddedDatabase ;
53+
4254 @ Mock
4355 private DataSource dataSource ;
4456
4557 @ Mock
4658 private LookupStrategy lookupStrategy ;
4759
60+ @ Mock
61+ JdbcOperations jdbcOperations ;
62+
63+ private JdbcAclService aclServiceIntegration ;
4864 private JdbcAclService aclService ;
4965
5066 @ Before
5167 public void setUp () {
52- aclService = new JdbcAclService (dataSource , lookupStrategy );
68+ aclService = new JdbcAclService (jdbcOperations , lookupStrategy );
69+ aclServiceIntegration = new JdbcAclService (embeddedDatabase , lookupStrategy );
70+ }
71+
72+ @ Before
73+ public void setUpEmbeddedDatabase () {
74+ embeddedDatabase = new EmbeddedDatabaseBuilder ()//
75+ .addScript ("createAclSchemaWithAclClassIdType.sql" )
76+ .addScript ("db/sql/test_data_hierarchy.sql" )
77+ .build ();
78+ }
79+
80+ @ After
81+ public void tearDownEmbeddedDatabase () {
82+ embeddedDatabase .shutdown ();
5383 }
5484
5585 // SEC-1898
@@ -60,8 +90,110 @@ public void readAclByIdMissingAcl() {
6090 lookupStrategy .readAclsById (anyList (),
6191 anyList ())).thenReturn (result );
6292 ObjectIdentity objectIdentity = new ObjectIdentityImpl (Object .class , 1 );
63- List <Sid > sids = Arrays .<Sid > asList (new PrincipalSid ("user" ));
93+ List <Sid > sids = Arrays .<Sid >asList (new PrincipalSid ("user" ));
6494
6595 aclService .readAclById (objectIdentity , sids );
6696 }
97+
98+ @ Test
99+ public void findOneChildren () {
100+ List <ObjectIdentity > result = new ArrayList <>();
101+ result .add (new ObjectIdentityImpl (Object .class , "5577" ));
102+ Object [] args = {"1" , "org.springframework.security.acls.jdbc.JdbcAclServiceTests$MockLongIdDomainObject" };
103+ when (
104+ jdbcOperations .query (anyString (),
105+ aryEq (args ), any (RowMapper .class ))).thenReturn (result );
106+ ObjectIdentity objectIdentity = new ObjectIdentityImpl (MockLongIdDomainObject .class , 1L );
107+
108+ List <ObjectIdentity > objectIdentities = aclService .findChildren (objectIdentity );
109+ assertThat (objectIdentities .size ()).isEqualTo (1 );
110+ assertThat (objectIdentities .get (0 ).getIdentifier ()).isEqualTo ("5577" );
111+ }
112+
113+ @ Test
114+ public void findNoChildren () {
115+ ObjectIdentity objectIdentity = new ObjectIdentityImpl (MockLongIdDomainObject .class , 1L );
116+
117+ List <ObjectIdentity > objectIdentities = aclService .findChildren (objectIdentity );
118+ assertThat (objectIdentities ).isNull ();
119+ }
120+
121+ // ~ Some integration tests
122+ // ========================================================================================================
123+
124+ @ Test
125+ public void findChildrenWithoutIdType () {
126+ ObjectIdentity objectIdentity = new ObjectIdentityImpl (MockLongIdDomainObject .class , 4711L );
127+
128+ List <ObjectIdentity > objectIdentities = aclServiceIntegration .findChildren (objectIdentity );
129+ assertThat (objectIdentities .size ()).isEqualTo (1 );
130+ assertThat (objectIdentities .get (0 ).getType ()).isEqualTo (MockUntypedIdDomainObject .class .getName ());
131+ assertThat (objectIdentities .get (0 ).getIdentifier ()).isEqualTo (5000L );
132+ }
133+
134+ @ Test
135+ public void findChildrenForUnknownObject () {
136+ ObjectIdentity objectIdentity = new ObjectIdentityImpl (Object .class , 33 );
137+
138+ List <ObjectIdentity > objectIdentities = aclServiceIntegration .findChildren (objectIdentity );
139+ assertThat (objectIdentities ).isNull ();
140+ }
141+
142+ @ Test
143+ public void findChildrenOfIdTypeLong () {
144+ ObjectIdentity objectIdentity = new ObjectIdentityImpl ("location" , "US-PAL" );
145+
146+ List <ObjectIdentity > objectIdentities = aclServiceIntegration .findChildren (objectIdentity );
147+ assertThat (objectIdentities .size ()).isEqualTo (2 );
148+ assertThat (objectIdentities .get (0 ).getType ()).isEqualTo (MockLongIdDomainObject .class .getName ());
149+ assertThat (objectIdentities .get (0 ).getIdentifier ()).isEqualTo (4711L );
150+ assertThat (objectIdentities .get (1 ).getType ()).isEqualTo (MockLongIdDomainObject .class .getName ());
151+ assertThat (objectIdentities .get (1 ).getIdentifier ()).isEqualTo (4712L );
152+ }
153+
154+ @ Test
155+ public void findChildrenOfIdTypeString () {
156+ ObjectIdentity objectIdentity = new ObjectIdentityImpl ("location" , "US" );
157+
158+ aclServiceIntegration .setAclClassIdSupported (true );
159+ List <ObjectIdentity > objectIdentities = aclServiceIntegration .findChildren (objectIdentity );
160+ assertThat (objectIdentities .size ()).isEqualTo (1 );
161+ assertThat (objectIdentities .get (0 ).getType ()).isEqualTo ("location" );
162+ assertThat (objectIdentities .get (0 ).getIdentifier ()).isEqualTo ("US-PAL" );
163+ }
164+
165+ @ Test
166+ public void findChildrenOfIdTypeUUID () {
167+ ObjectIdentity objectIdentity = new ObjectIdentityImpl (MockUntypedIdDomainObject .class , 5000L );
168+
169+ aclServiceIntegration .setAclClassIdSupported (true );
170+ List <ObjectIdentity > objectIdentities = aclServiceIntegration .findChildren (objectIdentity );
171+ assertThat (objectIdentities .size ()).isEqualTo (1 );
172+ assertThat (objectIdentities .get (0 ).getType ()).isEqualTo ("costcenter" );
173+ assertThat (objectIdentities .get (0 ).getIdentifier ()).isEqualTo (UUID .fromString ("25d93b3f-c3aa-4814-9d5e-c7c96ced7762" ));
174+ }
175+
176+ private class MockLongIdDomainObject {
177+ private Object id ;
178+
179+ public Object getId () {
180+ return id ;
181+ }
182+
183+ public void setId (Object id ) {
184+ this .id = id ;
185+ }
186+ }
187+
188+ private class MockUntypedIdDomainObject {
189+ private Object id ;
190+
191+ public Object getId () {
192+ return id ;
193+ }
194+
195+ public void setId (Object id ) {
196+ this .id = id ;
197+ }
198+ }
67199}
0 commit comments