Skip to content

Commit 6695784

Browse files
committed
Polish Logging
Issue gh-14801
1 parent 801e808 commit 6695784

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/metadata/OpenSamlMetadataResolver.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
import javax.xml.namespace.QName;
2727

2828
import net.shibboleth.utilities.java.support.xml.SerializeSupport;
29+
import org.apache.commons.logging.Log;
30+
import org.apache.commons.logging.LogFactory;
2931
import org.opensaml.core.xml.XMLObjectBuilder;
3032
import org.opensaml.core.xml.config.XMLObjectProviderRegistrySupport;
3133
import org.opensaml.saml.common.xml.SAMLConstants;
@@ -65,6 +67,8 @@ public final class OpenSamlMetadataResolver implements Saml2MetadataResolver {
6567
OpenSamlInitializationService.initialize();
6668
}
6769

70+
private final Log logger = LogFactory.getLog(this.getClass());
71+
6872
private final EntityDescriptorMarshaller entityDescriptorMarshaller;
6973

7074
private final EntitiesDescriptorMarshaller entitiesDescriptorMarshaller;
@@ -116,6 +120,9 @@ private EntityDescriptor entityDescriptor(RelyingPartyRegistration registration)
116120
if (this.signMetadata) {
117121
return OpenSamlSigningUtils.sign(entityDescriptor, registration);
118122
}
123+
else {
124+
this.logger.trace("Did not sign metadata since `signMetadata` is `false`");
125+
}
119126
return entityDescriptor;
120127
}
121128

0 commit comments

Comments
 (0)