Proposal: Replace .size() == 0 with .isEmpty() for Lists and Maps

Author: kwonyonghyun

acl/src/main/java/org/springframework/security/acls/domain/AclImpl.java

@@ -202,7 +202,7 @@ public boolean isGranted(List<Permission> permission, List<Sid> sids, boolean ad
 	public boolean isSidLoaded(List<Sid> sids) {
 		// If loadedSides is null, this indicates all SIDs were loaded
 		// Also return true if the caller didn't specify a SID to find
-		if ((this.loadedSids == null) || (sids == null) || (sids.size() == 0)) {
+		if ((this.loadedSids == null) || (sids == null) || sids.isEmpty()) {
 			return true;
 		}
 

acl/src/main/java/org/springframework/security/acls/domain/DefaultPermissionFactory.java

@@ -140,7 +140,7 @@ public Permission buildFromName(String name) {
 
 	@Override
 	public List<Permission> buildFromNames(List<String> names) {
-		if ((names == null) || (names.size() == 0)) {
+		if ((names == null) || names.isEmpty()) {
 			return Collections.emptyList();
 		}
 		List<Permission> permissions = new ArrayList<>(names.size());

config/src/main/java/org/springframework/security/config/http/UserDetailsServiceFactoryBean.java

@@ -101,10 +101,10 @@ else if (bean instanceof UserDetailsService) {
 	 */
 	private UserDetailsService getUserDetailsService() {
 		Map<String, ?> beans = getBeansOfType(CachingUserDetailsService.class);
-		if (beans.size() == 0) {
+		if (beans.isEmpty()) {
 			beans = getBeansOfType(UserDetailsService.class);
 		}
-		if (beans.size() == 0) {
+		if (beans.isEmpty()) {
 			throw new ApplicationContextException("No UserDetailsService registered.");
 		}
 		if (beans.size() > 1) {
@@ -124,7 +124,7 @@ public void setApplicationContext(ApplicationContext beanFactory) throws BeansEx
 		// Check ancestor bean factories if they exist and the current one has none of the
 		// required type
 		BeanFactory parent = this.beanFactory.getParentBeanFactory();
-		while (parent != null && beans.size() == 0) {
+		while (parent != null && beans.isEmpty()) {
 			if (parent instanceof ListableBeanFactory) {
 				beans = ((ListableBeanFactory) parent).getBeansOfType(type);
 			}

core/src/main/java/org/springframework/security/access/intercept/RunAsManagerImpl.java

@@ -80,7 +80,7 @@ public Authentication buildRunAs(Authentication authentication, Object object,
 				newAuthorities.add(extraAuthority);
 			}
 		}
-		if (newAuthorities.size() == 0) {
+		if (newAuthorities.isEmpty()) {
 			return null;
 		}
 		// Add existing authorities

core/src/main/java/org/springframework/security/core/userdetails/jdbc/JdbcDaoImpl.java

@@ -182,7 +182,7 @@ protected void initDao() throws ApplicationContextException {
 	@Override
 	public UserDetails loadUserByUsername(String username) throws UsernameNotFoundException {
 		List<UserDetails> users = loadUsersByUsername(username);
-		if (users.size() == 0) {
+		if (users.isEmpty()) {
 			this.logger.debug("Query returned no results for user '" + username + "'");
 			throw new UsernameNotFoundException(this.messages.getMessage("JdbcDaoImpl.notFound",
 					new Object[] { username }, "Username {0} not found"));
@@ -197,7 +197,7 @@ public UserDetails loadUserByUsername(String username) throws UsernameNotFoundEx
 		}
 		List<GrantedAuthority> dbAuths = new ArrayList<>(dbAuthsSet);
 		addCustomAuthorities(user.getUsername(), dbAuths);
-		if (dbAuths.size() == 0) {
+		if (dbAuths.isEmpty()) {
 			this.logger.debug("User '" + username + "' has no authorities and will be treated as 'not found'");
 			throw new UsernameNotFoundException(this.messages.getMessage("JdbcDaoImpl.noAuthority",
 					new Object[] { username }, "User {0} has no GrantedAuthority"));

ldap/src/test/java/org/apache/directory/server/core/avltree/ArrayMarshaller.java

@@ -73,7 +73,7 @@ public ArrayMarshaller(Comparator<E> comparator) {
 	 * @param tree the tree to be marshalled
 	 */
 	public byte[] serialize(ArrayTree<E> tree) {
-		if ((tree == null) || (tree.size() == 0)) {
+		if ((tree == null) || tree.isEmpty()) {
 			return EMPTY_TREE;
 		}
 

taglibs/src/main/java/org/springframework/security/taglibs/authz/AbstractAuthorizeTag.java

@@ -207,7 +207,7 @@ private WebInvocationPrivilegeEvaluator getPrivilegeEvaluator() throws IOExcepti
 		ApplicationContext ctx = SecurityWebApplicationContextUtils
 			.findRequiredWebApplicationContext(getServletContext());
 		Map<String, WebInvocationPrivilegeEvaluator> wipes = ctx.getBeansOfType(WebInvocationPrivilegeEvaluator.class);
-		if (wipes.size() == 0) {
+		if (wipes.isEmpty()) {
 			throw new IOException(
 					"No visible WebInvocationPrivilegeEvaluator instance could be found in the application "
 							+ "context. There must be at least one in order to support the use of URL access checks in 'authorize' tags.");

taglibs/src/main/java/org/springframework/security/taglibs/authz/AccessControlListTag.java

@@ -163,7 +163,7 @@ private <T> T getBeanOfType(Class<T> type) throws JspException {
 			.getParent()) {
 			map.putAll(context.getBeansOfType(type));
 		}
-		if (map.size() == 0) {
+		if (map.isEmpty()) {
 			return null;
 		}
 		if (map.size() == 1) {

web/src/main/java/org/springframework/security/web/FilterChainProxy.java

@@ -211,7 +211,7 @@ private void doFilterInternal(ServletRequest request, ServletResponse response,
 		FirewalledRequest firewallRequest = this.firewall.getFirewalledRequest((HttpServletRequest) request);
 		HttpServletResponse firewallResponse = this.firewall.getFirewalledResponse((HttpServletResponse) response);
 		List<Filter> filters = getFilters(firewallRequest);
-		if (filters == null || filters.size() == 0) {
+		if (filters == null || filters.isEmpty()) {
 			if (logger.isTraceEnabled()) {
 				logger.trace(LogMessage.of(() -> "No security for " + requestLine(firewallRequest)));
 			}