Enhance IpAddressMatcher performance

ahmd-nabil · ahmd-nabil · commit 2e6a20f2978d · 2024-01-27T01:02:11.000+02:00
Closes gh-14493 Signed-off-by: ahmd-nabil <ahm3dnabil99@gmail.com>
diff --git a/web/src/main/java/org/springframework/security/web/util/matcher/IpAddressMatcher.java b/web/src/main/java/org/springframework/security/web/util/matcher/IpAddressMatcher.java
@@ -56,8 +56,9 @@ public IpAddressMatcher(String ipAddress) {
 			this.nMaskBits = -1;
 		}
 		this.requiredAddress = parseAddress(ipAddress);
-		Assert.isTrue(this.requiredAddress.getAddress().length * 8 >= this.nMaskBits,
-				String.format("IP address %s is too short for bitmask of length %d", ipAddress, this.nMaskBits));
+		String finalIpAddress = ipAddress;
+		Assert.isTrue(this.requiredAddress.getAddress().length * 8 >= this.nMaskBits, () -> String
+			.format("IP address %s is too short for bitmask of length %d", finalIpAddress, this.nMaskBits));
 	}
 
 	@Override

Original file line number	Diff line number	Diff line change
`@@ -56,8 +56,9 @@ public IpAddressMatcher(String ipAddress) {`
`56`	`56`	`this.nMaskBits = -1;`
`57`	`57`	`}`
`58`	`58`	`this.requiredAddress = parseAddress(ipAddress);`
`59`		`- Assert.isTrue(this.requiredAddress.getAddress().length * 8 >= this.nMaskBits,`
`60`		`- String.format("IP address %s is too short for bitmask of length %d", ipAddress, this.nMaskBits));`
	`59`	`+ String finalIpAddress = ipAddress;`
	`60`	`+ Assert.isTrue(this.requiredAddress.getAddress().length * 8 >= this.nMaskBits, () -> String`
	`61`	`+ .format("IP address %s is too short for bitmask of length %d", finalIpAddress, this.nMaskBits));`
`61`	`62`	`}`
`62`	`63`
`63`	`64`	`@Override`