Skip to content

Improve support for @Nested and @NestedTestConfiguration in various test framework contracts #30310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wilkinsona opened this issue Apr 11, 2023 · 1 comment
Labels
in: test Issues in the test module status: pending-design-work Needs design work before any code can be developed type: documentation A documentation task type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

This is related to #31456.

It's unclear to me exactly where support for @Nested and @NestedTestConfiguration fits into the test framework's various contracts. Clarifying that would, I hope, make it easier to understand which APIs and utility methods support @Nested and which require implementers of those contracts to roll their own support. Hopefully the situations where implementers need to roll their own support can then be reduced and, ideally, eliminated entirely.

One specific example is AnnotationConfigContextLoaderUtils. I'm rather confused about the purpose and general utility of AnnotationConfigContextLoaderUtils if it doesn't support @Nested and @NestedTestConfiguration semantics.

Perhaps this would be better handled as two issues? One to make some additions to the javadoc to describe the current situation and steer implementers in the right direction and a second to reduce the cases where implementers need to do anything at all.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 11, 2023
@bclozel bclozel added the in: test Issues in the test module label Apr 11, 2023
@sbrannen sbrannen added type: documentation A documentation task type: enhancement A general enhancement status: pending-design-work Needs design work before any code can be developed and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 7, 2023
@sbrannen sbrannen self-assigned this Jul 7, 2023
@sbrannen sbrannen added this to the 6.1.x milestone Jul 7, 2023
@snicoll
Copy link
Member

snicoll commented Dec 22, 2023

@sbrannen is this a documentation or are they any API change scheduled? An issue can't be both. If API changes are expected, I'd argue we probably need to reconsider the milestone.

@jhoeller jhoeller modified the milestones: 6.1.x, 6.2.x Jan 11, 2024
@bclozel bclozel changed the title Improve support for @Nested and @NestedTestConfiguration in various test framework contracts Improve support for @Nested and @NestedTestConfiguration in various test framework contracts Feb 14, 2024
@sbrannen sbrannen changed the title Improve support for @Nested and @NestedTestConfiguration in various test framework contracts Improve support for @Nested and @NestedTestConfiguration in various test framework contracts Feb 14, 2024
@sbrannen sbrannen modified the milestones: 6.2.x, 6.2.0-M1, 6.2.0-M2 Mar 18, 2024
@sbrannen sbrannen modified the milestones: 6.2.0-M2, 6.2.x May 12, 2024
@sbrannen sbrannen modified the milestones: 6.2.x, General Backlog Sep 8, 2024
@sbrannen sbrannen modified the milestones: General Backlog, 7.0.x Dec 3, 2024
@sbrannen sbrannen removed their assignment Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module status: pending-design-work Needs design work before any code can be developed type: documentation A documentation task type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

6 participants