Why MockMvcResultMatchers has not a xpath method with org.hamcrest.Matcher<T>? [SPR-13687]

[spring-projects-issues]

Manuel Jordan opened SPR-13687 and commented

Hello

Just curious and in a someway confused.

If the MockMvcResultMatchers class has the jsonPath method with the following signatures:

• jsonPath(String expression, org.hamcrest.Matcher<T> matcher)
• jsonPath(String expression, Object... args)

And the xpath method with the following signatures:

• xpath(String expression, Map<String,String> namespaces, Object... args)
• xpath(String expression, Object... args)

Why does not exist?

• xpath(String expression, org.hamcrest.Matcher<T> matcher)

I think very valuable use hamcrest for XML too.

---

Affects: 4.2 GA

Issue Links:

• Introduce JsonPath matchers for empty and non-empty content [SPR-13352] #17936 Introduce JsonPath matchers for empty and non-empty content
• XpathExpectationsHelper should support Hamcrest matching against typed objects [SPR-14722] #19287 XpathExpectationsHelper should support Hamcrest matching against typed objects

[spring-projects-issues]

Rossen Stoyanchev commented

The two jsonPath methods pretty much cover the options in JsonPathResultMatchers. The XpathResultMatchers on the other hand has more overloaded options, so the two xpath methods in MockMvcResultMatchers gather only the common input, and then you have to do "." and pick the option you want.

That said a shortcut for xpath(String expression, org.hamcrest.Matcher<T> matcher) should be okay to provide.

[spring-projects-issues]

Juergen Hoeller commented

Having a quick look at this, wouldn't we need overloaded methods for String/number/boolean matchers, in order to delegate to XpathResultMatchers?

Let's rather target this for 4.3 instead.

Juergen

[spring-projects-issues]

Manuel Jordan commented

Thanks a lot by your support.

[spring-projects-issues]

Rossen Stoyanchev commented

On taking a closer look, I recall now why it's set up this way. It's the difference between the JsonPath and XPath support. If you look at XpathExpectationsHelper you'll see what it takes to invoke it. We already expose all the available options.