Skip to content

Commit cc1f578

Browse files
sada-sigscirstoyanchev
authored andcommitted
Remove charset from content-type in SseEmitter
See gh-24632
1 parent b2fe494 commit cc1f578

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/SseEmitter.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@ public class SseEmitter extends ResponseBodyEmitter {
4141

4242
static final MediaType TEXT_PLAIN = new MediaType("text", "plain", StandardCharsets.UTF_8);
4343

44-
static final MediaType TEXT_EVENTSTREAM = new MediaType("text", "event-stream", StandardCharsets.UTF_8);
45-
46-
4744
/**
4845
* Create a new SseEmitter instance.
4946
*/
@@ -70,7 +67,7 @@ protected void extendResponse(ServerHttpResponse outputMessage) {
7067

7168
HttpHeaders headers = outputMessage.getHeaders();
7269
if (headers.getContentType() == null) {
73-
headers.setContentType(TEXT_EVENTSTREAM);
70+
headers.setContentType(MediaType.TEXT_EVENT_STREAM);
7471
}
7572
}
7673

spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ResponseBodyEmitterReturnValueHandlerTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ public void sseEmitter() throws Exception {
211211
emitter.send(SseEmitter.event().
212212
comment("a test").name("update").id("1").reconnectTime(5000L).data(bean1).data(bean2));
213213

214-
assertThat(this.response.getContentType()).isEqualTo("text/event-stream;charset=UTF-8");
214+
assertThat(this.response.getContentType()).isEqualTo("text/event-stream");
215215
assertThat(this.response.getContentAsString()).isEqualTo((":a test\n" +
216216
"event:update\n" +
217217
"id:1\n" +
@@ -238,7 +238,7 @@ public void responseBodyFlux() throws Exception {
238238
processor.onNext("baz");
239239
processor.onComplete();
240240

241-
assertThat(this.response.getContentType()).isEqualTo("text/event-stream;charset=UTF-8");
241+
assertThat(this.response.getContentType()).isEqualTo("text/event-stream");
242242
assertThat(this.response.getContentAsString()).isEqualTo("data:foo\n\ndata:bar\n\ndata:baz\n\n");
243243
}
244244

@@ -272,7 +272,7 @@ public void responseEntitySse() throws Exception {
272272

273273
assertThat(this.request.isAsyncStarted()).isTrue();
274274
assertThat(this.response.getStatus()).isEqualTo(200);
275-
assertThat(this.response.getContentType()).isEqualTo("text/event-stream;charset=UTF-8");
275+
assertThat(this.response.getContentType()).isEqualTo("text/event-stream");
276276
assertThat(this.response.getHeader("foo")).isEqualTo("bar");
277277
}
278278

0 commit comments

Comments
 (0)