Skip to content

Commit c13dfc5

Browse files
committed
Merge pull request #29889 from xavier-b:main
* gh-29889: Use DataBuffer::toString instead of CharBuffer
2 parents f9884e0 + b7d53ac commit c13dfc5

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

spring-core/src/main/java/org/springframework/core/codec/StringDecoder.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package org.springframework.core.codec;
1818

19-
import java.nio.CharBuffer;
2019
import java.nio.charset.Charset;
2120
import java.nio.charset.StandardCharsets;
2221
import java.util.ArrayList;
@@ -189,9 +188,8 @@ public String decode(DataBuffer dataBuffer, ResolvableType elementType,
189188
@Nullable MimeType mimeType, @Nullable Map<String, Object> hints) {
190189

191190
Charset charset = getCharset(mimeType);
192-
CharBuffer charBuffer = charset.decode(dataBuffer.toByteBuffer());
191+
String value = dataBuffer.toString(charset);
193192
DataBufferUtils.release(dataBuffer);
194-
String value = charBuffer.toString();
195193
LogFormatUtils.traceDebug(logger, traceOn -> {
196194
String formatted = LogFormatUtils.formatValue(value, !traceOn);
197195
return Hints.getLogPrefix(hints) + "Decoded " + formatted;

spring-web/src/main/java/org/springframework/http/codec/FormHttpMessageReader.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package org.springframework.http.codec;
1818

1919
import java.net.URLDecoder;
20-
import java.nio.CharBuffer;
2120
import java.nio.charset.Charset;
2221
import java.nio.charset.StandardCharsets;
2322
import java.util.Collections;
@@ -129,8 +128,7 @@ public Mono<MultiValueMap<String, String>> readMono(ResolvableType elementType,
129128

130129
return DataBufferUtils.join(message.getBody(), this.maxInMemorySize)
131130
.map(buffer -> {
132-
CharBuffer charBuffer = charset.decode(buffer.toByteBuffer());
133-
String body = charBuffer.toString();
131+
String body = buffer.toString(charset);
134132
DataBufferUtils.release(buffer);
135133
MultiValueMap<String, String> formData = parseFormData(charset, body);
136134
logFormData(formData, hints);

0 commit comments

Comments
 (0)