Skip to content

Commit 5288641

Browse files
diguagesnicoll
authored andcommitted
Refactor duplicated code
See gh-1445
1 parent a1a6157 commit 5288641

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

spring-core/src/main/java/org/springframework/core/StandardReflectionParameterNameDiscoverer.java

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -33,21 +33,15 @@ public class StandardReflectionParameterNameDiscoverer implements ParameterNameD
3333

3434
@Override
3535
public String[] getParameterNames(Method method) {
36-
Parameter[] parameters = method.getParameters();
37-
String[] parameterNames = new String[parameters.length];
38-
for (int i = 0; i < parameters.length; i++) {
39-
Parameter param = parameters[i];
40-
if (!param.isNamePresent()) {
41-
return null;
42-
}
43-
parameterNames[i] = param.getName();
44-
}
45-
return parameterNames;
36+
return getParameterNames(method.getParameters());
4637
}
4738

4839
@Override
4940
public String[] getParameterNames(Constructor<?> ctor) {
50-
Parameter[] parameters = ctor.getParameters();
41+
return getParameterNames(ctor.getParameters());
42+
}
43+
44+
private String[] getParameterNames(Parameter[] parameters) {
5145
String[] parameterNames = new String[parameters.length];
5246
for (int i = 0; i < parameters.length; i++) {
5347
Parameter param = parameters[i];
@@ -58,5 +52,4 @@ public String[] getParameterNames(Constructor<?> ctor) {
5852
}
5953
return parameterNames;
6054
}
61-
6255
}

0 commit comments

Comments
 (0)